From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, ritesh.list@gmail.com,
djwong@kernel.org, mcgrof@kernel.org, gost.dev@samsung.com,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v3 2/3] generic/436: round up bufsz to nearest filesystem blksz
Date: Tue, 28 May 2024 09:12:46 +0000 [thread overview]
Message-ID: <20240528091246.jsicflatb6ndsc5g@quentin> (raw)
In-Reply-To: <20240527132637.3ncfgfpun374ygib@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Mon, May 27, 2024 at 09:26:37PM +0800, Zorro Lang wrote:
> On Mon, May 27, 2024 at 01:01:11PM +0000, Pankaj Raghav (Samsung) wrote:
> > On Mon, May 27, 2024 at 01:48:33PM +0200, Pankaj Raghav (Samsung) wrote:
> > > From: Pankaj Raghav <p.raghav@samsung.com>
> > >
> > > SEEK_HOLE and SEEK_DATA work in filesystem block size granularity. So
> > > while filling up the buffer for test 13 - 16, round up the bufsz to the
> > > closest filesystem blksz.
> > >
> > > As we only allowed blocksizes lower than the pagesize, this was never an
> > > issue and it always aligned. Once we have blocksize > pagesize, this
> > > assumption will break.
> > >
> > > Fixes the test for LBS configuration.
> > >
> > > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> > > Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> > Looks like I missed the RVB from Darrick [1].
> >
> > @Zorro could you fix it up before you commit?
>
> Sure, if there's not more review points, I'll merge it with this change.
Sounds good. Thanks!
next prev parent reply other threads:[~2024-05-28 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 11:48 [PATCH v3 0/3] more lbs test fixes Pankaj Raghav (Samsung)
2024-05-27 11:48 ` [PATCH v3 1/3] xfs/161: adapt the test case for 64k FS blocksize Pankaj Raghav (Samsung)
2024-05-27 11:48 ` [PATCH v3 2/3] generic/436: round up bufsz to nearest filesystem blksz Pankaj Raghav (Samsung)
2024-05-27 13:01 ` Pankaj Raghav (Samsung)
2024-05-27 13:26 ` Zorro Lang
2024-05-28 9:12 ` Pankaj Raghav (Samsung) [this message]
2024-05-27 11:48 ` [PATCH v3 3/3] xfs/008: use block size instead of the pagesize Pankaj Raghav (Samsung)
2024-05-27 17:03 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528091246.jsicflatb6ndsc5g@quentin \
--to=kernel@pankajraghav.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=ritesh.list@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.