From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Hannes Reinecke <hare@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@kernel.org>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATCHv2] block: check for max_hw_sectors underflow
Date: Tue, 28 May 2024 12:58:37 +0200 [thread overview]
Message-ID: <20240528105837.GA15290@lst.de> (raw)
In-Reply-To: <acf3e39c-36ae-4792-b870-26d392be5241@oracle.com>
On Tue, May 28, 2024 at 11:54:42AM +0100, John Garry wrote:
> I don't think that we ever check if lim->logical_block_size is a power-of-2
> - but that's a given, right?
It has to be for the block stack to work. That being said now that we
do have a single good place for sanity checks it's probably worth to
add this check explicitly.
next prev parent reply other threads:[~2024-05-28 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 10:46 [PATCHv2] block: check for max_hw_sectors underflow Hannes Reinecke
2024-05-28 6:29 ` Christoph Hellwig
2024-05-28 10:54 ` John Garry
2024-05-28 10:58 ` Christoph Hellwig [this message]
2024-05-28 13:54 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528105837.GA15290@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hare@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.