From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] memcg: Remove the lockdep assert from __mod_objcg_mlstate().
Date: Tue, 28 May 2024 15:40:27 +0200 [thread overview]
Message-ID: <20240528134027.OxDASsS3@linutronix.de> (raw)
In-Reply-To: <09e085bb-f09e-4901-a2dd-a0b789bb8a4d@kernel.org>
On 2024-05-28 14:34:55 [+0200], Vlastimil Babka (SUSE) wrote:
> > The safety of the counter update is already ensured by
> > VM_WARN_ON_IRQS_ENABLED() which is part of memcg_stats_lock() and does
> > not require yet another check.
>
> I think here it's __mod_memcg_lruvec_state() doing the VM_WARN_ON_ as we
> don't go through memcg_stats_lock()?
It is either VM_WARN_ON_IRQS_ENABLED() directly as in
__mod_memcg_lruvec_state() (which is special) or memcg_stats_lock().
Do you want me to rephrase this part?
Sebastian
next prev parent reply other threads:[~2024-05-28 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:19 [PATCH] memcg: Remove the lockdep assert from __mod_objcg_mlstate() Sebastian Andrzej Siewior
2024-05-28 12:34 ` Vlastimil Babka (SUSE)
2024-05-28 13:40 ` Sebastian Andrzej Siewior [this message]
2024-05-28 13:44 ` Vlastimil Babka (SUSE)
2024-05-28 14:13 ` [PATCH v2] " Sebastian Andrzej Siewior
2024-05-28 14:19 ` Vlastimil Babka (SUSE)
2024-05-28 14:59 ` Shakeel Butt
2024-05-28 15:07 ` Vlastimil Babka (SUSE)
2024-05-28 16:21 ` Shakeel Butt
2024-05-28 15:08 ` Sebastian Andrzej Siewior
2024-05-28 16:20 ` Shakeel Butt
2024-05-28 16:21 ` Shakeel Butt
2024-05-29 9:16 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528134027.OxDASsS3@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tglx@linutronix.de \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.