From: Al Viro <viro@zeniv.linux.org.uk>
To: Edward Adam Davis <eadavis@qq.com>
Cc: syzbot+fe42a669c87e4a980051@syzkaller.appspotmail.com,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tytso@mit.edu
Subject: Re: [PATCH] fs/dcache: fix warning in ext4_xattr_inode_lookup_create
Date: Wed, 29 May 2024 03:01:30 +0100 [thread overview]
Message-ID: <20240529020130.GK2118490@ZenIV> (raw)
In-Reply-To: <20240529015652.GJ2118490@ZenIV>
On Wed, May 29, 2024 at 02:56:52AM +0100, Al Viro wrote:
> On Wed, May 29, 2024 at 09:15:02AM +0800, Edward Adam Davis wrote:
> > ext4_xattr_inode_lookup_create() will use s_root, so set it to NULL
> > after do_one_tree().
>
> Why, in the name of everything unholy, would eviction of dentries need
> to set any kind of xattrs?
IOW, that might make the testcase STFU, but something odd is happening
there and I would really like to understand the details before we go
that way.
prev parent reply other threads:[~2024-05-29 2:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 15:21 [syzbot] [ext4?] WARNING in ext4_xattr_inode_lookup_create syzbot
2024-05-29 0:14 ` Edward Adam Davis
2024-05-29 0:53 ` syzbot
2024-05-29 1:15 ` [PATCH] fs/dcache: fix warning " Edward Adam Davis
2024-05-29 1:56 ` Al Viro
2024-05-29 2:01 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529020130.GK2118490@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=adilger.kernel@dilger.ca \
--cc=eadavis@qq.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+fe42a669c87e4a980051@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.