From: Jakub Kicinski <kuba@kernel.org>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: "Nicolas Pitre" <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Breno Leitao" <leitao@debian.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andrew Lunn" <andrew@lunn.ch>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Arnd Bergmann" <arnd@arndb.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: smc91x: Refactor SMC_* macros
Date: Wed, 29 May 2024 17:17:40 -0700 [thread overview]
Message-ID: <20240529171740.0643a5a1@kernel.org> (raw)
In-Reply-To: <20240528104421.399885-3-thorsten.blum@toblux.com>
On Tue, 28 May 2024 12:44:23 +0200 Thorsten Blum wrote:
> Use the macro parameter lp directly instead of relying on ioaddr being
> defined in the surrounding scope.
Have you tested this, or just compile tested (please mention what
testing has been done in the commit message in the future)?
What's the motivation - cleanup or this helps remove some warnings?
(again, please mention in the commit message)
AFAICT this will break smc_probe().
--
pw-bot: cr
next prev parent reply other threads:[~2024-05-30 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 10:44 [PATCH net-next] net: smc91x: Refactor SMC_* macros Thorsten Blum
2024-05-28 12:08 ` Andrew Lunn
2024-05-30 0:17 ` Jakub Kicinski [this message]
2024-05-30 1:53 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529171740.0643a5a1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@toblux.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.