From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h
Date: Thu, 30 May 2024 02:02:53 -0400 [thread overview]
Message-ID: <20240530020213-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240527060126.12578-1-thuth@redhat.com>
On Mon, May 27, 2024 at 08:01:26AM +0200, Thomas Huth wrote:
> When running the update-linx-headers.sh script, it currently fails with:
>
> scripts/update-linux-headers.sh: line 73: .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory
>
> The "include" folder is obviously missing here - no clue how this could
> have worked before?
>
> Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Paolo you merged the offending patch wanna merge this one?
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index fbf7e119bc..23afe8c08a 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -159,7 +159,7 @@ for arch in $ARCHLIST; do
> cp_portable "$hdrdir/bootparam.h" \
> "$output/include/standard-headers/asm-$arch"
> cp_portable "$hdrdir/include/asm/setup_data.h" \
> - "$output/standard-headers/asm-x86"
> + "$output/include/standard-headers/asm-x86"
> fi
> if [ $arch = riscv ]; then
> cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/"
> --
> 2.45.1
prev parent reply other threads:[~2024-05-30 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 6:01 [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h Thomas Huth
2024-05-27 14:58 ` Cornelia Huck
2024-05-29 23:28 ` Michael Roth
2024-05-30 6:02 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530020213-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.