All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: yocto-patches@lists.yoctoproject.org
Cc: Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [yocto-patches] [PATCH meta-rockchip] rockchip-extlinux.inc: fix non-fit KERNEL_IMAGETYPE image boot
Date: Thu, 30 May 2024 10:11:44 -0400	[thread overview]
Message-ID: <20240530141144.GA23102@localhost> (raw)
In-Reply-To: <20240527-non-fit-fdt-boot-v1-1-72bf2530547d@cherry.de>

On Mon 2024-05-27 @ 03:48:24 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> On systems where KERNEL_IMAGETYPE is not set to fitImage, one needs to
> either pass an DTB or a path to a directory where DTBs are located on
> the rootfs.
> 
> When FDT property in extlinux is provided, FDTDIR isn't used (and
> actually u-boot-extlinux-config doesn't even write it to the
> configuration file).
> 
> When relative paths are used, they are relative to the directory where
> extlinux.conf is stored[1]. Since the DTBs are stored in /boot, just
> providing the filename of the DTB won't work because extlinux in U-Boot
> will search for it in /boot/extlinux. We should therefore either use ../
> prefix for relative paths or use /boot to make it absolute. /boot is
> more explicit and easily parseable, so let's use the latter.
> 
> [1] https://wiki.syslinux.org/wiki/index.php?title=Config#Working_directory
> 
> Fixes: d80fa46c42f2 ("rockchip-extlinux.inc: handle multiple DTs in KERNEL_DEVICETREE")
> Fixes: 3b51866f2251 ("remove /boot partition")
> Fixes: 13316b796814 ("KERNEL_DEVICETREE: 32-bit re-org")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>  conf/machine/include/rockchip-extlinux.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Trevor Woerner <twoerner@gmail.com>
Applied to meta-rockchip, master branch. Thanks!


  reply	other threads:[~2024-05-30 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 13:48 [PATCH meta-rockchip] rockchip-extlinux.inc: fix non-fit KERNEL_IMAGETYPE image boot Quentin Schulz
2024-05-30 14:11 ` Trevor Woerner [this message]
2024-05-31  8:50   ` [yocto-patches] " Quentin Schulz
2024-06-04 18:04     ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240530141144.GA23102@localhost \
    --to=twoerner@gmail.com \
    --cc=quentin.schulz@cherry.de \
    --cc=yocto-patches@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.