All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] tst_test: Don't print hints if failed to acquire
Date: Thu, 30 May 2024 16:49:16 +0200	[thread overview]
Message-ID: <20240530144916.GA512984@pevik> (raw)
In-Reply-To: <ZldrDNzrnXcI9XJ7@yuki>

Hi Cyril,

> Hi!
> This is a great catch but I do not think that it should be limited to
> the device init. We should distable the hints during the whole library
> setup and only enable them once we actually start running the test.

+1. I suspected that, but did not have enough time to explore. Thanks for
raising this.

> I guess that we need:

I'll try to test it, hopefully next week. Or feel free to send your patch
and just put me in some tag (e.g.  Co-developed-by:, but not that important).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-05-30 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 20:28 [LTP] [PATCH 1/2] tst_device: Print info about acquiring device Petr Vorel
2024-05-27 20:28 ` [LTP] [PATCH 2/2] tst_test: Don't print hints if failed to acquire Petr Vorel
2024-05-29 17:51   ` Cyril Hrubis
2024-05-30 14:49     ` Petr Vorel [this message]
2024-05-28  6:03 ` [LTP] [PATCH 1/2] tst_device: Print info about acquiring device Andrea Cervesato via ltp
2024-05-28  7:50   ` Wei Gao via ltp
2024-05-29 15:34 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240530144916.GA512984@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.