From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B53E17D071; Fri, 31 May 2024 06:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717135715; cv=none; b=bRnvjZ78Qoj9s2r43zsWybd/JnW1BqUurHDsb82kYwZvLL37gFTMTBaEShtWMz4VytE5kNX9eBEJzk6i8nFB/iUs3mOoOraJ71SO3bagrFqeknxZMsT0wAzHqstvvpV2uJ4xSiBKVfmFKKhY3/5pKFnb0vWxeDRENdqyvOfSgyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717135715; c=relaxed/simple; bh=9Lq7tTCG32vvV5D4xtot6/ifQLTN+b3T5AJN9EhOLao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WwoMWsenjvJScSXiDi+KKLN76ay+SxzFQHFGPHnfzRw4KQ+EBUrvX81XAhCR2Z4Ok2gYA1cpw4Zfqz36hs+/bp908ouKr05i35eI+1ne6saWXxQXOztjJiiP/28zM9HeF4hKc4WeyfOYYI1RPdE9soR6Ctmk6ra7CpU/JUhGtuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id CE58A68BEB; Fri, 31 May 2024 08:08:27 +0200 (CEST) Date: Fri, 31 May 2024 08:08:27 +0200 From: Christoph Hellwig To: Michael Ellerman Cc: "Linux regression tracking (Thorsten Leemhuis)" , John Garry , Jens Axboe , "Martin K. Petersen" , Damien Le Moal , Niklas Cassel , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, Guenter Roeck , Christoph Hellwig , Linux kernel regressions list Subject: Re: [PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue Message-ID: <20240531060827.GA17723@lst.de> References: <20240520151536.GA32532@lst.de> <8734pz4gdh.fsf@mail.lhotse> <87wmnb2x2y.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmnb2x2y.fsf@mail.lhotse> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, May 31, 2024 at 12:28:21AM +1000, Michael Ellerman wrote: > No that's wrong. The actual hardware page size is 4K, but > CONFIG_PAGE_SIZE and PAGE_SHIFT etc. is 64K. > > So at least for this user the driver used to work with 64K pages, and > now doesn't. Which suggested that the communicated max_hw_sectors is wrong, and previously we were saved by the block layer increasing it to PAGE_SIZE after a warning. Should we just increment it to 64k? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 416D4C25B75 for ; Fri, 31 May 2024 06:09:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VrCPb20Stz3cGC for ; Fri, 31 May 2024 16:09:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) Received: from verein.lst.de (unknown [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VrCP36SbQz30T1 for ; Fri, 31 May 2024 16:08:46 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id CE58A68BEB; Fri, 31 May 2024 08:08:27 +0200 (CEST) Date: Fri, 31 May 2024 08:08:27 +0200 From: Christoph Hellwig To: Michael Ellerman Subject: Re: [PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue Message-ID: <20240531060827.GA17723@lst.de> References: <20240520151536.GA32532@lst.de> <8734pz4gdh.fsf@mail.lhotse> <87wmnb2x2y.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmnb2x2y.fsf@mail.lhotse> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , "Martin K. Petersen" , "Linux regression tracking \(Thorsten Leemhuis\)" , John Garry , linux-block@vger.kernel.org, Niklas Cassel , Damien Le Moal , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , Guenter Roeck , Linux kernel regressions list Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 31, 2024 at 12:28:21AM +1000, Michael Ellerman wrote: > No that's wrong. The actual hardware page size is 4K, but > CONFIG_PAGE_SIZE and PAGE_SHIFT etc. is 64K. > > So at least for this user the driver used to work with 64K pages, and > now doesn't. Which suggested that the communicated max_hw_sectors is wrong, and previously we were saved by the block layer increasing it to PAGE_SIZE after a warning. Should we just increment it to 64k?