From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7A51367 for ; Fri, 31 May 2024 00:28:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717115307; cv=none; b=Ka2H6IcVW8AidPEXzMwuLKmrJVeRZwaZLZTvgtFYXubt2gyeqkgZ6TheDLz4cMN6uscjldYGtCa4RHy/go7STlOR1l3ZjvG8P+qf7AfZleez+EMMlW80cBK3jH4hDkmvRgfzQN0gv5mxQQYxzuWRnytQ15ac1xmoJxcGm3xg+kM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717115307; c=relaxed/simple; bh=ed4Jpucv0SyK9RYrWVa8iEpWUZbW+UIPQj2RL5LdfHs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OyZvvnPllv0lJw4aT0IJJH4g2+RyIdYNc87HulvGfoGbKMZlrB3dgpKs882Bb1YZZBUrxLCvzaWjB6u8dhQx0g8tVOr8LbI92cd/RKW4p5bMt3RDfGgeVLnuRoCWy0RIkwGFLA8DQRxbDP3GNKNdzyRY/QunHvlHduwCr+9EDzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bejbmjxW; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bejbmjxW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717115306; x=1748651306; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ed4Jpucv0SyK9RYrWVa8iEpWUZbW+UIPQj2RL5LdfHs=; b=bejbmjxWTPGtlYWfqbVq21K4NEU/EVsIVad801ayGzaxjGx09klJuXEp m0tsxqpCHlSnne7i6YuT5X7qCfzmIKeVPac92jRBR7ZJk8fXRf9QIVFOx dP4e4wSknnawH+rBHfxxnofCk6AN0RELvnNRKpFykJv4jsSWS5Na5JxdC 3L4RcrugNegBVTYlY+4++Q244nOfPuScrbqArGC0zvu95/73obE0kFiKX UXsol494zgrg0uIWSNUrlMtVBrqIMLD+4sMkZr6VR17cMdBbw9p7PNIJl NDdRIjo+uY7vmJgQJkw12f8UKsC6lxFoPaHDnnqPW/R5WNORRfj2A7ij3 A==; X-CSE-ConnectionGUID: XmHnU/tFSEK+TqB6jDgODQ== X-CSE-MsgGUID: v05aSn0oQcaQjbD/lMvG+g== X-IronPort-AV: E=McAfee;i="6600,9927,11088"; a="31174572" X-IronPort-AV: E=Sophos;i="6.08,202,1712646000"; d="scan'208";a="31174572" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 17:28:25 -0700 X-CSE-ConnectionGUID: WF8e6GNVSjuElKXSRK+MiQ== X-CSE-MsgGUID: JlzRA6JwQ5a6fgbBAyUHSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,202,1712646000"; d="scan'208";a="73477419" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by orviesa001.jf.intel.com with ESMTP; 30 May 2024 17:28:23 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sCq85-000GH7-0C; Fri, 31 May 2024 00:28:21 +0000 Date: Fri, 31 May 2024 08:28:14 +0800 From: kernel test robot To: Oleg Nesterov , Thomas Gleixner Cc: oe-kbuild-all@lists.linux.dev, Anna-Maria Behnsen , Frederic Weisbecker , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tick: shift tick_nohz_switch_to_nohz() from tick_check_oneshot_change() to hrtimer_run_queues() Message-ID: <202405310818.JPmNHEjC-lkp@intel.com> References: <20240530124203.GA26990@redhat.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530124203.GA26990@redhat.com> Hi Oleg, kernel test robot noticed the following build errors: [auto build test ERROR on tip/timers/core] [also build test ERROR on linus/master v6.10-rc1 next-20240529] [cannot apply to tip/timers/nohz] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Oleg-Nesterov/tick-shift-tick_nohz_switch_to_nohz-from-tick_check_oneshot_change-to-hrtimer_run_queues/20240530-204940 base: tip/timers/core patch link: https://lore.kernel.org/r/20240530124203.GA26990%40redhat.com patch subject: [PATCH] tick: shift tick_nohz_switch_to_nohz() from tick_check_oneshot_change() to hrtimer_run_queues() config: i386-randconfig-001-20240531 (https://download.01.org/0day-ci/archive/20240531/202405310818.JPmNHEjC-lkp@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405310818.JPmNHEjC-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405310818.JPmNHEjC-lkp@intel.com/ All errors (new ones prefixed by >>): ld: kernel/time/hrtimer.o: in function `hrtimer_run_queues': >> kernel/time/hrtimer.c:1898:(.text+0x1e71): undefined reference to `tick_nohz_switch_to_nohz' vim +1898 kernel/time/hrtimer.c 1874 1875 /* 1876 * Called from run_local_timers in hardirq context every jiffy 1877 */ 1878 void hrtimer_run_queues(void) 1879 { 1880 struct hrtimer_cpu_base *cpu_base = this_cpu_ptr(&hrtimer_bases); 1881 unsigned long flags; 1882 ktime_t now; 1883 1884 if (hrtimer_hres_active(cpu_base)) 1885 return; 1886 1887 /* 1888 * This _is_ ugly: We have to check periodically, whether we 1889 * can switch to highres and / or nohz mode. The clocksource 1890 * switch happens with xtime_lock held. Notification from 1891 * there only sets the check bit in the tick_oneshot code, 1892 * otherwise we might deadlock vs. xtime_lock. 1893 */ 1894 if (tick_check_oneshot_change()) { 1895 if (hrtimer_is_hres_enabled()) 1896 hrtimer_switch_to_hres(); 1897 else > 1898 tick_nohz_switch_to_nohz(); 1899 return; 1900 } 1901 1902 raw_spin_lock_irqsave(&cpu_base->lock, flags); 1903 now = hrtimer_update_base(cpu_base); 1904 1905 if (!ktime_before(now, cpu_base->softirq_expires_next)) { 1906 cpu_base->softirq_expires_next = KTIME_MAX; 1907 cpu_base->softirq_activated = 1; 1908 raise_softirq_irqoff(HRTIMER_SOFTIRQ); 1909 } 1910 1911 __hrtimer_run_queues(cpu_base, now, flags, HRTIMER_ACTIVE_HARD); 1912 raw_spin_unlock_irqrestore(&cpu_base->lock, flags); 1913 } 1914 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki