From: Sam Ravnborg <sam@ravnborg.org>
To: Sui Jingfeng <sui.jingfeng@linux.dev>,
Jayesh Choudhary <j-choudhary@ti.com>
Cc: Jayesh Choudhary <j-choudhary@ti.com>,
linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
mripard@kernel.org, jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
airlied@gmail.com, daniel@ffwll.ch, a-bhatia1@ti.com,
dri-devel@lists.freedesktop.org
Subject: Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook
Date: Fri, 31 May 2024 15:33:24 +0200 [thread overview]
Message-ID: <20240531133324.GA1715839@ravnborg.org> (raw)
In-Reply-To: <e5ce13e6-1007-41c9-bedc-2045d6f75480@linux.dev>
Hi Jayesh,
> > +
> > static const struct drm_bridge_funcs sii902x_bridge_funcs = {
> > .attach = sii902x_bridge_attach,
> > .mode_set = sii902x_bridge_mode_set,
> > @@ -516,6 +529,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs = {
> > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> > .atomic_get_input_bus_fmts = sii902x_bridge_atomic_get_input_bus_fmts,
> > .atomic_check = sii902x_bridge_atomic_check,
> > + .mode_valid = sii902x_bridge_mode_valid,
As you have the possibility to test the driver, it would be nice with a
follow-up patch that replaces the use of enable() / disable() with the
atomic counterparts.
enable() / disable() are deprecated, so it is nice to reduce their use.
Sam
next prev parent reply other threads:[~2024-05-31 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 9:29 [PATCH v4 0/2] Add mode_valid and atomic_check hooks for sii902x bridge Jayesh Choudhary
2024-05-30 9:29 ` [PATCH v4 1/2] drm/bridge: sii902x: Fix mode_valid hook Jayesh Choudhary
2024-05-30 23:30 ` Dmitry Baryshkov
2024-05-31 13:20 ` [v4,1/2] " Sui Jingfeng
2024-05-31 13:33 ` Sam Ravnborg [this message]
2024-05-31 14:04 ` Sui Jingfeng
2024-06-12 5:21 ` Jayesh Choudhary
2024-05-30 9:29 ` [PATCH v4 2/2] drm/bridge: Add pixel clock check in atomic_check Jayesh Choudhary
2024-05-30 9:34 ` Maxime Ripard
2024-05-30 9:50 ` Jayesh Choudhary
2024-05-31 12:55 ` [PATCH v4 0/2] Add mode_valid and atomic_check hooks for sii902x bridge Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531133324.GA1715839@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j-choudhary@ti.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=sui.jingfeng@linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.