From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod][PATCH 3/8] tools: tests: fix unused variables
Date: Fri, 31 May 2024 21:45:07 +0800 [thread overview]
Message-ID: <20240531134512.443850-4-warthog618@gmail.com> (raw)
In-Reply-To: <20240531134512.443850-1-warthog618@gmail.com>
Fix shellckeck SC2034[1] - foo appears unused.
Prefix intentionally unused variables with "_" and remove variables
not actually used.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
[1] https://www.shellcheck.net/wiki/SC2034
---
tools/gpio-tools-test.bash | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/gpio-tools-test.bash b/tools/gpio-tools-test.bash
index 6bbb06c..b065296 100755
--- a/tools/gpio-tools-test.bash
+++ b/tools/gpio-tools-test.bash
@@ -146,7 +146,7 @@ gpiosim_wait_value() {
local CHIPNAME=${GPIOSIM_CHIP_NAME[$1]}
local PORT=$GPIOSIM_SYSFS/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/value
- for i in {1..30}; do
+ for _i in {1..30}; do
[ "$(<$PORT)" = "$EXPECTED" ] && return
sleep 0.01
done
@@ -159,7 +159,6 @@ gpiosim_cleanup() {
local NAME=${GPIOSIM_APP_NAME}-$$-$CHIP
local DEVPATH=$GPIOSIM_CONFIGFS/$NAME
- local BANKPATH=$DEVPATH/bank0
echo 0 > $DEVPATH/live
find "$DEVPATH" -type d -name hog -exec rmdir '{}' '+'
@@ -229,13 +228,13 @@ dut_readable() {
}
dut_flush() {
- local JUNK
+ local _JUNK
lines=()
output=
unset DUT_FIRST_CHAR
- while read -t 0 -u ${COPROC[0]} JUNK
+ while read -t 0 -u "${COPROC[0]}" _JUNK
do
- read -t 0.1 -u ${COPROC[0]} JUNK || true
+ read -t 0.1 -u "${COPROC[0]}" _JUNK || true
done
}
--
2.39.2
next prev parent reply other threads:[~2024-05-31 13:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 13:45 [libgpiod][PATCH 0/8] tools: tests: fix shellcheck warnings Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 1/8] tools: tests: don't mix string and array Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 2/8] tools: tests: don't declare and assign separately Kent Gibson
2024-06-03 8:52 ` Bartosz Golaszewski
2024-06-03 8:58 ` Kent Gibson
2024-06-03 10:38 ` Bartosz Golaszewski
2024-06-03 10:39 ` Kent Gibson
2024-05-31 13:45 ` Kent Gibson [this message]
2024-05-31 13:45 ` [libgpiod][PATCH 4/8] tools: tests: use read -r to avoid mangling backslashes Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 5/8] tools: tests: don't use variables in printf format string Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 6/8] tools: tests: check exit code directly Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 7/8] tools: tests: shellcheck don't follow sourced file Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 8/8] tools: tests: avoid splitting and globbing Kent Gibson
2024-06-03 10:40 ` [libgpiod][PATCH 0/8] tools: tests: fix shellcheck warnings Bartosz Golaszewski
2024-06-03 10:43 ` Kent Gibson
2024-06-03 10:59 ` Kent Gibson
2024-06-03 11:51 ` Bartosz Golaszewski
2024-06-03 14:59 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531134512.443850-4-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.