All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hilliard <james.hilliard1@gmail.com>
To: buildroot@buildroot.org
Cc: James Hilliard <james.hilliard1@gmail.com>
Subject: [Buildroot] [PATCH 1/1] utils/genrandconfig: drop glibc Linaro toolchain version check
Date: Fri, 31 May 2024 19:17:33 -0600	[thread overview]
Message-ID: <20240601011733.2964473-1-james.hilliard1@gmail.com> (raw)

It has been well over 10 years since glibc 2.14 was released, I don't
think we need this check anymore.

The distutils module is no longer bundled with python 3.12 so this
eliminates the need to install additional python modules under python
3.12.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 utils/genrandconfig | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/utils/genrandconfig b/utils/genrandconfig
index b838dda34d..0889be0d43 100755
--- a/utils/genrandconfig
+++ b/utils/genrandconfig
@@ -25,8 +25,6 @@ import os
 from random import randint
 import sys
 import traceback
-from distutils.version import StrictVersion
-import platform
 
 
 class SystemInfo:
@@ -166,23 +164,6 @@ async def is_toolchain_usable(configfile, config):
             print("      Missing: %s" % toolchainline.strip(), file=sys.stderr)
             return False
 
-    # The latest Linaro toolchains on x86-64 hosts requires glibc
-    # 2.14+ on the host.
-    if platform.machine() == 'x86_64':
-        if 'BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y\n' in configlines or \
-           'BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64=y\n' in configlines or \
-           'BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE=y\n' in configlines or \
-           'BR2_TOOLCHAIN_EXTERNAL_LINARO_ARMEB=y\n' in configlines:
-            proc = await asyncio.create_subprocess_exec(
-                'ldd', '--version', stdout=asyncio.subprocess.PIPE)
-            ldd_version_output, _ = await proc.communicate()
-            if proc.returncode:
-                return False
-            glibc_version = ldd_version_output.decode().splitlines()[0].split()[-1]
-            if StrictVersion('2.14') > StrictVersion(glibc_version):
-                print("WARN: ignoring the Linaro ARM toolchains because too old host glibc", file=sys.stderr)
-                return False
-
     return True
 
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2024-06-01  1:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-01  1:17 James Hilliard [this message]
2024-06-03 20:40 ` [Buildroot] [PATCH 1/1] utils/genrandconfig: drop glibc Linaro toolchain version check Yann E. MORIN
2024-06-08 18:19 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240601011733.2964473-1-james.hilliard1@gmail.com \
    --to=james.hilliard1@gmail.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.