From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com,
Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
dsahern@kernel.org
Subject: Re: [PATCH net] inet: bring NLM_DONE out to a separate recv() in inet_dump_ifaddr()
Date: Sat, 1 Jun 2024 16:10:13 -0700 [thread overview]
Message-ID: <20240601161013.10d5e52c@hermes.local> (raw)
In-Reply-To: <20240601212517.644844-1-kuba@kernel.org>
On Sat, 1 Jun 2024 14:25:17 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> + * When used in combination with for_each_netdev_dump() - make sure to
> + * invalidate the ifindex when iteration is done. for_each_netdev_dump()
> + * does not move the iterator index "after" the last valid entry.
> + *
> + * NOTE: Do not use this helper for dumps without known legacy users!
> + * Most families are accessed only using well-written libraries
> + * so starting to coalesce NLM_DONE is perfectly fine, and more efficient.
Sorry, I disagree.
You can't just fix the problem areas. The split was an ABI change, and there could
be a problem in any dump. This the ABI version of the old argument
If a tree falls in a forest and no one is around to hear it, does it make a sound?
All dumps must behave the same. You are stuck with the legacy behavior.
next prev parent reply other threads:[~2024-06-01 23:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 21:25 [PATCH net] inet: bring NLM_DONE out to a separate recv() in inet_dump_ifaddr() Jakub Kicinski
2024-06-01 23:10 ` Stephen Hemminger [this message]
2024-06-01 23:48 ` Jakub Kicinski
2024-06-02 2:23 ` David Ahern
2024-06-02 10:00 ` Eric Dumazet
2024-06-02 22:21 ` Jakub Kicinski
2024-06-03 13:54 ` Jakub Kicinski
2024-06-03 14:22 ` Eric Dumazet
2024-06-03 14:59 ` Jakub Kicinski
2024-06-03 15:26 ` Eric Dumazet
2024-06-02 21:59 ` Jakub Kicinski
2024-06-03 2:42 ` David Ahern
2024-06-03 14:05 ` Jamal Hadi Salim
2024-06-03 15:33 ` David Ahern
2024-06-03 15:34 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240601161013.10d5e52c@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jaroslav.pulchart@gooddata.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.