From: Al Viro <viro@zeniv.linux.org.uk>
To: Hyeonwoo Cha <chw1119@hanyang.ac.kr>
Cc: david.sterba@suse.com, aivazian.tigran@gmail.com,
brauner@kernel.org, jack@suse.cz, tytso@mit.edu,
adilger.kernel@dilger.ca, hirofumi@mail.parknet.co.jp,
sfr@canb.auug.org.au, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
reiserfs-devel@vger.kernel.org
Subject: Re: [PATCH] Fix filesystem issue: description of the fix Fix mark_buffer_dirty_inode to mark_buffer_dirty_fsync Signed-off-by: HyeonWoo Cha <chw1119@hanyang.ac.kr>
Date: Mon, 3 Jun 2024 08:35:51 +0100 [thread overview]
Message-ID: <20240603073551.GM1629371@ZenIV> (raw)
In-Reply-To: <20240603065910.20736-1-chw1119@hanyang.ac.kr>
On Mon, Jun 03, 2024 at 03:59:10PM +0900, Hyeonwoo Cha wrote:
NAK. Reasons:
* patch described as a fix; that implies that some behaviour
change is there. Yet there's no description of that change or
explanation of the problem being fixed.
* lack of _any_ explanations, period. Including e.g.
a discussion of the reasons why the change makes sense.
* apparent blind trust in continued applicability of comments
that date back to 2002; in any case, no analysis is offered anywhere -
reviewers are supposed to do that themselves, presumably.
* failure to Cc the original author of the comment in question.
prev parent reply other threads:[~2024-06-03 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 6:59 [PATCH] Fix filesystem issue: description of the fix Fix mark_buffer_dirty_inode to mark_buffer_dirty_fsync Signed-off-by: HyeonWoo Cha <chw1119@hanyang.ac.kr> Hyeonwoo Cha
2024-06-03 7:35 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603073551.GM1629371@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=adilger.kernel@dilger.ca \
--cc=aivazian.tigran@gmail.com \
--cc=brauner@kernel.org \
--cc=chw1119@hanyang.ac.kr \
--cc=david.sterba@suse.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.