Re: [PATCH 2/2] net: phy: Replace PHY_ANEG_TIMEOUT with Kconfig symbol

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

On Sat, Jun 01, 2024 at 11:21:54AM +0200, Francesco Dolcini wrote:
> Hello Marek,
> 
> On Fri, May 31, 2024 at 06:47:17PM +0200, Marek Vasut wrote:
> > Switch PHY_ANEG_TIMEOUT to CONFIG_PHY_ANEG_TIMEOUT Kconfig symbol.
> > This removes one more configuration headers option finalizes its
> > Kconfig symbol conversion. No functional change expected.
> > 
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> > ---
> ...
> 
> > diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
> > index 0df3917e200..6fd43511ee4 100644
> > --- a/include/configs/apalis_imx6.h
> > +++ b/include/configs/apalis_imx6.h
> > @@ -22,7 +22,6 @@
> >  #define CFG_SYS_FSL_USDHC_NUM	3
> >  
> >  /* Network */
> > -#define PHY_ANEG_TIMEOUT		15000 /* PHY needs longer aneg time */
> 
> You should remove also the line before, after removing the define it's
> just a stale comment.

It would be nice, but there's lots of similar garbage remaining from
other transitions, so to me it's not a deal-breaker here.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]