From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "Sunil V L" <sunilvl@ventanamicro.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
qemu-riscv@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Sia Jee Heng" <jeeheng.sia@starfivetech.com>,
"Haibo1 Xu" <haibo1.xu@intel.com>,
"Anup Patel" <apatel@ventanamicro.com>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Weiwei Li" <liwei1518@gmail.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>
Subject: Re: [PATCH v2 00/12] Add support for RISC-V ACPI tests
Date: Tue, 4 Jun 2024 03:04:58 -0400 [thread overview]
Message-ID: <20240604030424-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAKmqyKPQDpo541dF_inV1imL4i6U3KgpeOTPf7TcD-qUwe_O=w@mail.gmail.com>
On Tue, Jun 04, 2024 at 01:29:28PM +1000, Alistair Francis wrote:
> On Fri, May 24, 2024 at 4:14 PM Sunil V L <sunilvl@ventanamicro.com> wrote:
> >
> > Currently, bios-table-test doesn't support RISC-V. This series enables
> > the framework changes required and basic testing. Things like NUMA
> > related test cases will be added later.
> >
> > This needs refactoring/renaming of ARM64 bios table tests. Importantly,
> > the test cases now look for the expected AML files under
> > tests/data/acpi/virt/aarch64 path instead of directly under
> > tests/data/acpi/virt. To keep test cases not to fail because of this
> > movement, they are updated to look for both paths first.
> >
> > As part of this effort, it is found that uefi-test-tools is currently
> > broken to build. So, updated its Makefile as well to use python based
> > edk2 build script.
>
> It would be great to get someone who knows the UEFI world better than I
> do to ack these changes, especially the first few patches
>
>
> Alistair
ACPI things look ok. I can merge this but will wait a week or so
more for more acks.
> >
> > The changes are also available at branch
> > https://gitlab.com/vlsunil/qemu/-/tree/riscv_bios_table_test_v2
> >
> > Changes since v1:
> > 1) Addressed feedback from Gerd and Alistair
> > 2) Rebased and added tags received
> >
> > Sunil V L (12):
> > uefi-test-tools/UefiTestToolsPkg: Add RISC-V support
> > uefi-test-tools: Add support for python based build script
> > tests/data/uefi-boot-images: Add RISC-V ISO image
> > qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them
> > tests/qtest/bios-tables-test.c: Add support for arch in path
> > tests/data/acpi/virt: Move ACPI tables under aarch64
> > meson.build: Add RISC-V to the edk2-target list
> > pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs
> > tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V
> > tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V
> > tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V
> > tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V
> >
> > meson.build | 2 +-
> > pc-bios/meson.build | 2 +
> > tests/data/acpi/rebuild-expected-aml.sh | 5 +-
> > tests/data/acpi/virt/{ => aarch64}/APIC | Bin
> > .../acpi/virt/{ => aarch64}/APIC.acpihmatvirt | Bin
> > .../acpi/virt/{ => aarch64}/APIC.topology | Bin
> > tests/data/acpi/virt/{ => aarch64}/DBG2 | Bin
> > tests/data/acpi/virt/{ => aarch64}/DSDT | Bin
> > .../acpi/virt/{ => aarch64}/DSDT.acpihmatvirt | Bin
> > tests/data/acpi/virt/{ => aarch64}/DSDT.memhp | Bin
> > tests/data/acpi/virt/{ => aarch64}/DSDT.pxb | Bin
> > .../acpi/virt/{ => aarch64}/DSDT.topology | Bin
> > tests/data/acpi/virt/{ => aarch64}/FACP | Bin
> > tests/data/acpi/virt/{ => aarch64}/GTDT | Bin
> > .../acpi/virt/{ => aarch64}/HMAT.acpihmatvirt | Bin
> > tests/data/acpi/virt/{ => aarch64}/IORT | Bin
> > tests/data/acpi/virt/{ => aarch64}/MCFG | Bin
> > tests/data/acpi/virt/{ => aarch64}/NFIT.memhp | Bin
> > tests/data/acpi/virt/{ => aarch64}/PPTT | Bin
> > .../acpi/virt/{ => aarch64}/PPTT.acpihmatvirt | Bin
> > .../acpi/virt/{ => aarch64}/PPTT.topology | Bin
> > tests/data/acpi/virt/{ => aarch64}/SLIT.memhp | Bin
> > tests/data/acpi/virt/{ => aarch64}/SPCR | Bin
> > .../acpi/virt/{ => aarch64}/SRAT.acpihmatvirt | Bin
> > tests/data/acpi/virt/{ => aarch64}/SRAT.memhp | Bin
> > .../data/acpi/virt/{ => aarch64}/SRAT.numamem | Bin
> > tests/data/acpi/virt/{ => aarch64}/SSDT.memhp | Bin
> > tests/data/acpi/virt/{ => aarch64}/VIOT | Bin
> > tests/data/acpi/virt/riscv64/APIC | Bin 0 -> 116 bytes
> > tests/data/acpi/virt/riscv64/DSDT | Bin 0 -> 3518 bytes
> > tests/data/acpi/virt/riscv64/FACP | Bin 0 -> 276 bytes
> > tests/data/acpi/virt/riscv64/MCFG | Bin 0 -> 60 bytes
> > tests/data/acpi/virt/riscv64/RHCT | Bin 0 -> 314 bytes
> > tests/data/acpi/virt/riscv64/SPCR | Bin 0 -> 80 bytes
> > .../bios-tables-test.riscv64.iso.qcow2 | Bin 0 -> 16896 bytes
> > tests/qtest/bios-tables-test.c | 93 ++++++++++++++----
> > tests/qtest/meson.build | 3 +
> > tests/uefi-test-tools/Makefile | 19 ++--
> > .../UefiTestToolsPkg/UefiTestToolsPkg.dsc | 6 +-
> > tests/uefi-test-tools/uefi-test-build.config | 52 ++++++++++
> > 40 files changed, 147 insertions(+), 35 deletions(-)
> > rename tests/data/acpi/virt/{ => aarch64}/APIC (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/APIC.acpihmatvirt (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/APIC.topology (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/DBG2 (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/DSDT (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/DSDT.acpihmatvirt (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/DSDT.memhp (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/DSDT.pxb (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/DSDT.topology (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/FACP (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/GTDT (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/HMAT.acpihmatvirt (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/IORT (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/MCFG (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/NFIT.memhp (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/PPTT (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/PPTT.acpihmatvirt (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/PPTT.topology (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/SLIT.memhp (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/SPCR (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/SRAT.acpihmatvirt (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/SRAT.memhp (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/SRAT.numamem (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/SSDT.memhp (100%)
> > rename tests/data/acpi/virt/{ => aarch64}/VIOT (100%)
> > create mode 100644 tests/data/acpi/virt/riscv64/APIC
> > create mode 100644 tests/data/acpi/virt/riscv64/DSDT
> > create mode 100644 tests/data/acpi/virt/riscv64/FACP
> > create mode 100644 tests/data/acpi/virt/riscv64/MCFG
> > create mode 100644 tests/data/acpi/virt/riscv64/RHCT
> > create mode 100644 tests/data/acpi/virt/riscv64/SPCR
> > create mode 100644 tests/data/uefi-boot-images/bios-tables-test.riscv64.iso.qcow2
> > create mode 100644 tests/uefi-test-tools/uefi-test-build.config
> >
> > --
> > 2.40.1
> >
prev parent reply other threads:[~2024-06-04 7:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 6:13 [PATCH v2 00/12] Add support for RISC-V ACPI tests Sunil V L
2024-05-24 6:14 ` [PATCH v2 01/12] uefi-test-tools/UefiTestToolsPkg: Add RISC-V support Sunil V L
2024-06-04 3:23 ` Alistair Francis
2024-05-24 6:14 ` [PATCH v2 02/12] uefi-test-tools: Add support for python based build script Sunil V L
2024-05-24 6:14 ` [PATCH v2 03/12] tests/data/uefi-boot-images: Add RISC-V ISO image Sunil V L
2024-05-24 6:14 ` [PATCH v2 04/12] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them Sunil V L
2024-06-18 12:34 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 05/12] tests/qtest/bios-tables-test.c: Add support for arch in path Sunil V L
2024-06-19 9:20 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64 Sunil V L
2024-05-27 10:12 ` Philippe Mathieu-Daudé
2024-05-27 15:16 ` Sunil V L
2024-06-19 9:17 ` Igor Mammedov
2024-06-19 9:20 ` Michael S. Tsirkin
2024-06-19 18:00 ` Sunil V L
2024-06-20 13:53 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 07/12] meson.build: Add RISC-V to the edk2-target list Sunil V L
2024-06-19 9:19 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 08/12] pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs Sunil V L
2024-06-19 9:35 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 09/12] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V Sunil V L
2024-06-19 9:43 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 10/12] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V Sunil V L
2024-06-04 3:26 ` Alistair Francis
2024-06-19 9:44 ` Igor Mammedov
2024-05-24 6:14 ` [PATCH v2 11/12] tests/qtest/bios-tables-test.c: Enable basic testing " Sunil V L
2024-06-04 3:27 ` Alistair Francis
2024-06-19 10:12 ` Igor Mammedov
2024-06-19 18:05 ` Sunil V L
2024-05-24 6:14 ` [PATCH v2 12/12] tests/qtest/bios-tables-test: Add expected ACPI data files " Sunil V L
2024-06-04 3:28 ` Alistair Francis
2024-06-19 11:07 ` Igor Mammedov
2024-06-04 3:29 ` [PATCH v2 00/12] Add support for RISC-V ACPI tests Alistair Francis
2024-06-04 7:04 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604030424-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ajones@ventanamicro.com \
--cc=alistair23@gmail.com \
--cc=anisinha@redhat.com \
--cc=apatel@ventanamicro.com \
--cc=berrange@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=dbarboza@ventanamicro.com \
--cc=haibo1.xu@intel.com \
--cc=imammedo@redhat.com \
--cc=jeeheng.sia@starfivetech.com \
--cc=kraxel@redhat.com \
--cc=liwei1518@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sunilvl@ventanamicro.com \
--cc=thuth@redhat.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.