All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Ivan Babrou <ivan@cloudflare.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: why does proc_fd_getattr() bother with S_ISDIR(inode->i_mode)?
Date: Tue, 4 Jun 2024 04:40:51 +0100	[thread overview]
Message-ID: <20240604034051.GP1629371@ZenIV> (raw)

	... when the only way to get to it is via ->getattr() in
proc_fd_inode_operations?  Note that proc_fd_inode_operations
has ->lookup() in it; it _can't_ be ->i_op of a non-directory.

	Am I missing something here?

             reply	other threads:[~2024-06-04  3:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  3:40 Al Viro [this message]
2024-06-04 17:35 ` why does proc_fd_getattr() bother with S_ISDIR(inode->i_mode)? Ivan Babrou
2024-06-04 17:40   ` Al Viro
2024-06-05 14:26     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604034051.GP1629371@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=ivan@cloudflare.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.