All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	andy.shevchenko@gmail.com, "Philip Howard" <phil@gadgetoid.com>,
	"Sean Young" <sean@mess.org>,
	"Chris Morgan" <macromorgan@hotmail.com>,
	"Stefan Wahren" <wahrenst@gmx.net>,
	linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org,
	"Nicola Di Lieto" <nicola.dilieto@gmail.com>,
	"Dhruva Gole" <d-gole@ti.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: pwm: Add pwm-gpio
Date: Tue, 4 Jun 2024 15:34:13 +0800	[thread overview]
Message-ID: <20240604073413.GA137333@rigel> (raw)
In-Reply-To: <1edbcf6d-92b7-4971-b8b2-a88cc96995e9@linaro.org>

On Tue, Jun 04, 2024 at 08:21:32AM +0200, Krzysztof Kozlowski wrote:
> On 04/06/2024 04:51, Kent Gibson wrote:
> > On Sun, Jun 02, 2024 at 10:33:08PM +0200, Linus Walleij wrote:
> >> From: Nicola Di Lieto <nicola.dilieto@gmail.com>
> >>
> >> Add bindings for PWM modulated by GPIO.
> >>
> >
> > Shouldn't the bindings be added after the driver?
>
> No. See submitting patches document.
>

Hmmm, ok, so "5. The Documentation/ portion of the patch should come in
the series before the code implementing the binding."[1]?

It just seems odd that you document something that doesn't exist yet.

Cheers,
Kent.

[1] https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html

  reply	other threads:[~2024-06-04  7:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02 20:33 [PATCH v6 0/2] pwm: Add GPIO PWM driver Linus Walleij
2024-06-02 20:33 ` [PATCH v6 1/2] dt-bindings: pwm: Add pwm-gpio Linus Walleij
2024-06-04  2:51   ` Kent Gibson
2024-06-04  6:21     ` Krzysztof Kozlowski
2024-06-04  7:34       ` Kent Gibson [this message]
2024-06-04  7:42         ` Krzysztof Kozlowski
2024-06-04  8:16           ` Kent Gibson
2024-06-04  8:26             ` Krzysztof Kozlowski
2024-06-04 13:38   ` Linus Walleij
2024-06-04 14:14     ` Conor Dooley
2024-06-04 20:54       ` Linus Walleij
2024-06-05 17:23         ` Conor Dooley
2024-06-02 20:33 ` [PATCH v6 2/2] pwm: Add GPIO PWM driver Linus Walleij
2024-06-03 20:34   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604073413.GA137333@rigel \
    --to=warthog618@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=macromorgan@hotmail.com \
    --cc=nicola.dilieto@gmail.com \
    --cc=phil@gadgetoid.com \
    --cc=robh@kernel.org \
    --cc=sean@mess.org \
    --cc=ukleinek@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.