From: Simon Horman <horms@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, dsahern@kernel.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next] net: allow rps/rfs related configs to be switched
Date: Tue, 4 Jun 2024 18:03:57 +0100 [thread overview]
Message-ID: <20240604170357.GB791188@kernel.org> (raw)
In-Reply-To: <20240531164440.13292-1-kerneljasonxing@gmail.com>
On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> is off, I found that I cannot easily enable/disable the config
> because of lack of the prompt when using 'make menuconfig'. Therefore,
> I decided to change rps/rfc related configs altogether.
>
> Signed-off-by: Jason Xing <kernelxing@tencent.com>
Hi Jason,
FWIIW, I think it would be appropriate to also add help text for each option.
And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.
Likewise for CONFIG_BQL, although that isn't strictly related to this
patch.
...
next prev parent reply other threads:[~2024-06-04 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 16:44 [PATCH net-next] net: allow rps/rfs related configs to be switched Jason Xing
2024-06-04 17:03 ` Simon Horman [this message]
2024-06-05 0:54 ` Jason Xing
2024-06-05 19:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604170357.GB791188@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.