From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D47E144303; Tue, 4 Jun 2024 15:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717515749; cv=none; b=sgxijqImJpsq58BnlGfeI7umX9GhDlv0TsaTe7tmam+80MsbI+2P8vdslokI1iHXEVJk7vwROpDkMmRnjOKwYu330e4GwsRIvo/RP/CCr9o33MmoOOe/oZbgwBpiRlXAYMxB26cclPtIlZCc6Wa3yEriCNBKxAlnh46wyKzdj0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717515749; c=relaxed/simple; bh=gvxpfHQ65oWsKW/gpsh/uvOZGyM//B6SX2D/4rQ0Nsc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NlwVQTTYvgoIMsEYPvFrQvG9MxB8eOpDjkoHlIqxiJrK9K1lHQOtwj9UxrJSEhtGfJQuFsxFvy7Jc2NGZR9WCVY6Wrf2iW0tzErYhsutb6tmHUX8rKh/DQERthyFJDZrz92SLZ2vlP+rvtn6KlpE9T+yIzYaIH4z//L4aw4NckI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1p0RL9O1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1p0RL9O1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AB18C2BBFC; Tue, 4 Jun 2024 15:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717515749; bh=gvxpfHQ65oWsKW/gpsh/uvOZGyM//B6SX2D/4rQ0Nsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1p0RL9O1txeF88r7BI4R3mZCPecX9o5eCeU291B62J/7N4Hkguvf1lfLd3cqQUs8P 4Y1/0W4FQ0ElqLZ7UU0nmattnWlXk/Z10eyZip8sZHsKgLIIU/ogQGQB9n7FHaJ/iv fP0oOcb6nC636FrLvgUA+RegIdHHg80BK9dpAXYI= Date: Tue, 4 Jun 2024 17:38:24 +0200 From: Greg Kroah-Hartman To: Joy Chakraborty Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Srinivas Kandagatla , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Vincent Shih , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rafal Milecki , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, manugautam@google.com Subject: Re: [PATCH v3 1/1] nvmem: Change return type of reg read/write to ssize_t Message-ID: <2024060445-amaze-sitter-88da@gregkh> References: <20240510082929.3792559-1-joychakr@google.com> <20240510082929.3792559-2-joychakr@google.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510082929.3792559-2-joychakr@google.com> On Fri, May 10, 2024 at 08:29:29AM +0000, Joy Chakraborty wrote: > Change return type of reg_read() and reg_write() callback to ssize_t for > nvmem suppliers to return number of bytes read/written to the nvmem core. > > Currently nvmem core assumes the amount of data read/written is equal > to what it has requested from the supplier, this return code facilitates > better error handling in the nvmem core. > > Signed-off-by: Joy Chakraborty I thought this would be two patches, one to change the return type, and the second to change the logic involved here (making it easier to notice the logic changes.) But it seems ok to me: Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98B1AC27C52 for ; Tue, 4 Jun 2024 15:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Lk1f5MUcI9uNvXsSil3YGFonkVcl7NCA9gnbBiEDgI=; b=lOpZlFjcJB9Q01 B5LerK9Av47Ac2Gv92bFDKoiq+tr+FcQ/zE46rvyZ0HSbGaaTpxoLy1xBS12CAkwSXHg1mYVM99gj UWHEQ/X/JEaBm0uAQvdfJfCh0lHxXyfl4EcIlnXbs9EqhNF0qmH3BhWPwSaEmypqu/49xdgyaNJHF g55VZnr9R2O2M8lRtO1hL0GpQhdmI3xfCvlcaTbvLCYGktc8LnursEXhaqc/x3MO+Z79JqI0A+/HB m7JAoSVisHHGuGBP2sNu64IvSMWhnkPwfgg4463djmirf6BTeGt2gQqmqGPPIYlTwHchjyLqmo4A0 mbf1wJ7eJaaNpCMW/CqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWJ5-00000002xos-1l1X; Tue, 04 Jun 2024 15:42:39 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWJ0-00000002xnW-0hMy; Tue, 04 Jun 2024 15:42:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14AA9CE10B9; Tue, 4 Jun 2024 15:42:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AB18C2BBFC; Tue, 4 Jun 2024 15:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717515749; bh=gvxpfHQ65oWsKW/gpsh/uvOZGyM//B6SX2D/4rQ0Nsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1p0RL9O1txeF88r7BI4R3mZCPecX9o5eCeU291B62J/7N4Hkguvf1lfLd3cqQUs8P 4Y1/0W4FQ0ElqLZ7UU0nmattnWlXk/Z10eyZip8sZHsKgLIIU/ogQGQB9n7FHaJ/iv fP0oOcb6nC636FrLvgUA+RegIdHHg80BK9dpAXYI= Date: Tue, 4 Jun 2024 17:38:24 +0200 From: Greg Kroah-Hartman To: Joy Chakraborty Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Srinivas Kandagatla , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Vincent Shih , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rafal Milecki , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, manugautam@google.com Subject: Re: [PATCH v3 1/1] nvmem: Change return type of reg read/write to ssize_t Message-ID: <2024060445-amaze-sitter-88da@gregkh> References: <20240510082929.3792559-1-joychakr@google.com> <20240510082929.3792559-2-joychakr@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510082929.3792559-2-joychakr@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_084234_403781_10C42A93 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 08:29:29AM +0000, Joy Chakraborty wrote: > Change return type of reg_read() and reg_write() callback to ssize_t for > nvmem suppliers to return number of bytes read/written to the nvmem core. > > Currently nvmem core assumes the amount of data read/written is equal > to what it has requested from the supplier, this return code facilitates > better error handling in the nvmem core. > > Signed-off-by: Joy Chakraborty I thought this would be two patches, one to change the return type, and the second to change the logic involved here (making it easier to notice the logic changes.) But it seems ok to me: Reviewed-by: Greg Kroah-Hartman _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACA27C27C53 for ; Tue, 4 Jun 2024 15:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CQFBuKMvyxtjA6QkomT2w4rxzKTk0tvkmUE8a2zqi8s=; b=lDa4Oitpywq20E VO0nLdoUG0+M4ERZpEslUZiMjBp1ixw4DAsyFDB2VRVWBauqySQqtewKyARvq/PUSSFW5U6/M/mQQ z8xDRA18phAtCndKd9Yo2WLUsMU10nv5HLTFZIT3q84YawGGLSkv1PupzxHCJJVT1Do0w1qhFZUVf k5aH8CL9X6bK6nmuAszCPN20L/tMbO8oYcQmf23/D156w1T7q85DHmG/ltXgrjCWIlJQlgrhMt8Fc JUB0cspwe4Uf47GP0NykFzH95Yq6YhprgLuM66wmfvAZf4QLkc0yAoXA5zOY9LrVrWY6h2Q5vcTQf fHxSSDKXkCvD4zbepZMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWJ6-00000002xpo-3JFb; Tue, 04 Jun 2024 15:42:40 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWJ0-00000002xnW-0hMy; Tue, 04 Jun 2024 15:42:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14AA9CE10B9; Tue, 4 Jun 2024 15:42:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AB18C2BBFC; Tue, 4 Jun 2024 15:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717515749; bh=gvxpfHQ65oWsKW/gpsh/uvOZGyM//B6SX2D/4rQ0Nsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1p0RL9O1txeF88r7BI4R3mZCPecX9o5eCeU291B62J/7N4Hkguvf1lfLd3cqQUs8P 4Y1/0W4FQ0ElqLZ7UU0nmattnWlXk/Z10eyZip8sZHsKgLIIU/ogQGQB9n7FHaJ/iv fP0oOcb6nC636FrLvgUA+RegIdHHg80BK9dpAXYI= Date: Tue, 4 Jun 2024 17:38:24 +0200 From: Greg Kroah-Hartman To: Joy Chakraborty Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Srinivas Kandagatla , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Vincent Shih , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rafal Milecki , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, manugautam@google.com Subject: Re: [PATCH v3 1/1] nvmem: Change return type of reg read/write to ssize_t Message-ID: <2024060445-amaze-sitter-88da@gregkh> References: <20240510082929.3792559-1-joychakr@google.com> <20240510082929.3792559-2-joychakr@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510082929.3792559-2-joychakr@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_084234_403781_10C42A93 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 08:29:29AM +0000, Joy Chakraborty wrote: > Change return type of reg_read() and reg_write() callback to ssize_t for > nvmem suppliers to return number of bytes read/written to the nvmem core. > > Currently nvmem core assumes the amount of data read/written is equal > to what it has requested from the supplier, this return code facilitates > better error handling in the nvmem core. > > Signed-off-by: Joy Chakraborty I thought this would be two patches, one to change the return type, and the second to change the logic involved here (making it easier to notice the logic changes.) But it seems ok to me: Reviewed-by: Greg Kroah-Hartman _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29052C25B78 for ; Tue, 4 Jun 2024 15:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ct8cDUYkSULJm1gn+lomXOrL6OjFZZOTEy00mfmvEgI=; b=qi40kRA0Y8LhlL BBqdRp3AkBqZ9/et12p2aWAHVXb/BF8mA8guuxfd4V8tjGkN2jK68BH920a3p1Mh4iQk+DWOrOnqo ENL8QWjiQtwDyTztv3sqDRzLsLw0H57N6apyg4f3BtIARzEY6jW5lYjQLxwPf889m6Iy9xWrB1HA3 pL4Wp9A0yVOqP/13iryYrtrK4RC+DDQ8K5vLbIknEo4XrKu4zyypKXHRaTN5acCORop1+waHpdjbp 8jGDJ6urTjVJOds9Y82OvOJXpkESuhesnnJbqZ7an34e3A9oUPl6RRTT9n/idSrcy4W/DnfsrrMj4 nbbC42H+x4BOLuSTuIew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWJ5-00000002xpA-3YVR; Tue, 04 Jun 2024 15:42:39 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWJ0-00000002xnW-0hMy; Tue, 04 Jun 2024 15:42:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14AA9CE10B9; Tue, 4 Jun 2024 15:42:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AB18C2BBFC; Tue, 4 Jun 2024 15:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717515749; bh=gvxpfHQ65oWsKW/gpsh/uvOZGyM//B6SX2D/4rQ0Nsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1p0RL9O1txeF88r7BI4R3mZCPecX9o5eCeU291B62J/7N4Hkguvf1lfLd3cqQUs8P 4Y1/0W4FQ0ElqLZ7UU0nmattnWlXk/Z10eyZip8sZHsKgLIIU/ogQGQB9n7FHaJ/iv fP0oOcb6nC636FrLvgUA+RegIdHHg80BK9dpAXYI= Date: Tue, 4 Jun 2024 17:38:24 +0200 From: Greg Kroah-Hartman To: Joy Chakraborty Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Srinivas Kandagatla , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Vincent Shih , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rafal Milecki , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, manugautam@google.com Subject: Re: [PATCH v3 1/1] nvmem: Change return type of reg read/write to ssize_t Message-ID: <2024060445-amaze-sitter-88da@gregkh> References: <20240510082929.3792559-1-joychakr@google.com> <20240510082929.3792559-2-joychakr@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510082929.3792559-2-joychakr@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_084234_403781_10C42A93 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 08:29:29AM +0000, Joy Chakraborty wrote: > Change return type of reg_read() and reg_write() callback to ssize_t for > nvmem suppliers to return number of bytes read/written to the nvmem core. > > Currently nvmem core assumes the amount of data read/written is equal > to what it has requested from the supplier, this return code facilitates > better error handling in the nvmem core. > > Signed-off-by: Joy Chakraborty I thought this would be two patches, one to change the return type, and the second to change the logic involved here (making it easier to notice the logic changes.) But it seems ok to me: Reviewed-by: Greg Kroah-Hartman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel