All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	Andrew Jones <andrew.jones@linux.dev>,
	kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH v2 2/2] gitlab-ci: Always save artifacts
Date: Wed,  5 Jun 2024 18:09:41 +1000	[thread overview]
Message-ID: <20240605080942.7675-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240605080942.7675-1-npiggin@gmail.com>

The unit test logs are important to have when a test fails so
mark these as always save.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 .gitlab-ci.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 23bb69e24..0e4d6205f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -4,14 +4,18 @@ before_script:
  - dnf update -y
  - dnf install -y make python
 
+# By default artifacts are only saved on success. This uses when:always
+# because the test logs are important to help diagnose failures.
 .intree_template:
  artifacts:
+  when: always
   expire_in: 2 days
   paths:
    - logs
 
 .outoftree_template:
  artifacts:
+  when: always
   expire_in: 2 days
   paths:
    - build/logs
-- 
2.43.0


  parent reply	other threads:[~2024-06-05  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  8:09 [kvm-unit-tests PATCH v2 0/2] misc docs/build/CI improvements Nicholas Piggin
2024-06-05  8:09 ` [kvm-unit-tests PATCH v2 1/2] doc: update unittests doc Nicholas Piggin
2024-06-05 10:46   ` Andrew Jones
2024-06-05  8:09 ` Nicholas Piggin [this message]
2024-06-05 10:51 ` [kvm-unit-tests PATCH v2 0/2] misc docs/build/CI improvements Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605080942.7675-3-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=andrew.jones@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.