From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, Mark Zhang <markzhang@nvidia.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Or Har-Toov <ohartoov@nvidia.com>,
Patrisious Haddad <phaddad@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-rc 1/6] RDMA/cache: Release GID table even if leak is detected
Date: Wed, 5 Jun 2024 08:47:55 -0300 [thread overview]
Message-ID: <20240605114755.GR19897@nvidia.com> (raw)
In-Reply-To: <20240605094456.GA19021@unreal>
On Wed, Jun 05, 2024 at 12:44:56PM +0300, Leon Romanovsky wrote:
> On Tue, Jun 04, 2024 at 01:36:36PM -0300, Jason Gunthorpe wrote:
> > On Tue, May 28, 2024 at 03:52:51PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@nvidia.com>
> > >
> > > When the table is released, we nullify pointer to GID table, it means
> > > that in case GID entry leak is detected, we will leak table too.
> > >
> > > Delete code that prevents table destruction.
> >
> > This converts a memory leak into a UAF, it doesn't seem like a good direction??
>
> Maybe we should convert dev_err() to be WARN_ON(). I didn't see any
> complains about GID entry leaks. It is debug print.
Yes WARN_ON is better
Jason
next prev parent reply other threads:[~2024-06-05 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:52 [PATCH rdma-rc 0/6] Batch of mlx5 fixes for v6.10 Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 1/6] RDMA/cache: Release GID table even if leak is detected Leon Romanovsky
2024-06-04 16:36 ` Jason Gunthorpe
2024-06-05 9:44 ` Leon Romanovsky
2024-06-05 11:47 ` Jason Gunthorpe [this message]
2024-06-21 13:21 ` Jason Gunthorpe
2024-06-24 13:23 ` Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 2/6] RDMA/mlx5: Remove extra unlock on error path Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 3/6] RDMA/mlx5: Follow rb_key.ats when creating new mkeys Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 4/6] RDMA/mlx5: Ensure created mkeys always have a populated rb_key Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 5/6] RDMA/mlx5: Fix unwind flow as part of mlx5_ib_stage_init_init Leon Romanovsky
2024-05-28 12:52 ` [PATCH rdma-rc 6/6] RDMA/mlx5: Add check for srq max_sge attribute Leon Romanovsky
2024-06-02 8:30 ` [PATCH rdma-rc 0/6] Batch of mlx5 fixes for v6.10 Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605114755.GR19897@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=michaelgur@nvidia.com \
--cc=ohartoov@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.