Re: [yocto-patches] [PATCH meta-rockchip master scarthgap v3 00/16] various reworks around u-boot and rkbin + fixes for MACHINEOVERRIDES

[Trevor Woerner <twoerner@gmail.com>]

On Fri 2024-05-31 @ 11:25:07 AM, Quentin Schulz via lists.yoctoproject.org wrote:
> This does a few reworks of how we handle TF-A and DDR bin blob
> dependencies, hopefully in a way that makes it much easier to add
> support for new SoCs without having to touch too many files.
> 
> While at it, add an SOC_FAMILY entry for rk3588s/rk3588 boards.
> 
> Additionally, make rk3308 use the PREFERRED_PROVIDER mechanism to select
> rk3308-rkbin instead of rockchip-rkbin.
> 
> Finally, fix a few MACHINEOVERRIDES ordering issues.

Here are the new MACHINEOVERRIDES (with these patches applied) for all the
MACHINEs we support (with rk-u-boot-env enabled):

	MACHINEOVERRIDES="armv7ve:rockchip:rk3288:firefly-rk3288:rk-u-boot-env"
	MACHINEOVERRIDES="armv7a:rockchip:rk3066:marsboard-rk3066"
	MACHINEOVERRIDES="armv7a:rockchip:rk3188:radxarock"
	MACHINEOVERRIDES="armv7ve:rockchip:rk3288:rock2-square"
	MACHINEOVERRIDES="armv7ve:rockchip:rk3288:tinker-board:rk-u-boot-env"
	MACHINEOVERRIDES="armv7ve:rockchip:rk3288:tinker-board-s:rk-u-boot-env"
	MACHINEOVERRIDES="armv7ve:rockchip:rk3288:vyasa-rk3288:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:nanopi-m4:nanopi-m4:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:nanopi-m4:nanopi-m4-2gb:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:nanopi-m4b:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:rk3328:nanopi-r2s:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:nanopi-r4s:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa76-cortexa55:rockchip:closed-tpl:rk3588s:rk3588:orangepi-5-plus:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:closed-tpl:rk3308:roc-rk3308-cc:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:rk3328:roc-rk3328-cc:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:closed-tpl:rk3568:rock-3a:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:rock-pi-4:rock-4c-plus:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa76-cortexa55:rockchip:closed-tpl:rk3588s:rock-5a:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa76-cortexa55:rockchip:closed-tpl:rk3588s:rk3588:rock-5b:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:rock-pi-4:rock-pi-4a:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:rock-pi-4:rock-pi-4b:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:cortexa72-cortexa53:rockchip:rk3399:rock-pi-4:rock-pi-4c:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:rk3328:rock-pi-e:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:closed-tpl:rk3308:rock-pi-s:rk-u-boot-env"
	MACHINEOVERRIDES="aarch64:rockchip:rk3328:rock64:rk-u-boot-env"

For uniformity, would it be nicer to have all MACHINEs include the SoC
OVERRIDE?

Other than that this patch set looks great!

I'm not overly fond of the name "u-boot-rockchip.inc" since it sounds like
it's an inc file for building the rockchip vendor fork of u-boot, but I can't
really think of anything that is obviously nicer.