From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1B10C25B76 for ; Wed, 5 Jun 2024 17:49:28 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=q6XGPEKJ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VvZj2515Lz30Vr for ; Thu, 6 Jun 2024 03:49:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=q6XGPEKJ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VvZh30gPnz30St for ; Thu, 6 Jun 2024 03:48:35 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 31FEACE1838; Wed, 5 Jun 2024 17:48:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E54DC2BD11; Wed, 5 Jun 2024 17:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717609705; bh=enupfRHuA/sUxcPvYiVVg7oNNALRyFrXlotRKy7IvuM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q6XGPEKJV+EC0QMabsGEV9vd0/gyTkTUfF+TAEXj9Jy82MgO8X2lzIXWqIRAyBC86 p4XFyPX0I/WfDCqM65cOTJJ9NtKpl/hvtdUdsUpBcVVWkFc3jG6Q8rAEkBNStkNJs5 EeMBLlqRH+zZaZrNfQwk35LbS5N95a8bjDH9lzLQvjv7h1K8dVURxuxRCT3CuS5mlI wnRXZtwm4GPtEcZMOi8f5BwtzvNtu9FnvxuB9E0f0+/V3OOEXYLQmrnZIKL2mBm75A Cuee7zNrJx1tzlb/W2d4QWFOgOXgEjONB2UVOHmux2fi2SBrWeUwLfey2ouK6lGMGA PlcBGDPnUqH0w== Date: Wed, 5 Jun 2024 18:48:17 +0100 From: Simon Horman To: Serge Semin Subject: Re: [PATCH net-next v2 07/10] net: pcs: xpcs: Add Synopsys DW xPCS platform device driver Message-ID: <20240605174817.GQ791188@kernel.org> References: <20240602143636.5839-1-fancer.lancer@gmail.com> <20240602143636.5839-8-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240602143636.5839-8-fancer.lancer@gmail.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Tomer Maimon , Alexandre Torgue , Eric Dumazet , Krzysztof Kozlowski , Sagar Cheluvegowda , Florian Fainelli , openbmc@lists.ozlabs.org, Russell King , Maxime Chevallier , Jose Abreu , Abhishek Chauhan , Jakub Kicinski , Paolo Abeni , Andrew Halaney , Jose Abreu , devicetree@vger.kernel.org, Conor Dooley , Jiawen Wu , Mengyuan Lou , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Vladimir Oltean , "David S. Miller" , Heiner Kallweit Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Sun, Jun 02, 2024 at 05:36:21PM +0300, Serge Semin wrote: ... > diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c ... > +const struct dev_pm_ops xpcs_plat_pm_ops = { > + SET_RUNTIME_PM_OPS(xpcs_plat_pm_runtime_suspend, > + xpcs_plat_pm_runtime_resume, > + NULL) > +}; nit: xpcs_plat_pm_ops only seems to be used in this file. If so it should probably be static. Flagged by Sparse. ... > +static struct platform_driver xpcs_plat_driver = { > + .probe = xpcs_plat_probe, > + .driver = { > + .name = "dwxpcs", > + .pm = &xpcs_plat_pm_ops, > + .of_match_table = xpcs_of_ids, > + }, > +}; > +module_platform_driver(xpcs_plat_driver); ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 861E01CFBC; Wed, 5 Jun 2024 17:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717609705; cv=none; b=N9myrhPn+fA6hdWg0uUU7lDBhJpAsSuMGGa0S9pa6eKb8x69E5oWuxSF4rptkhtRyEZlJ0UtuWw0L7WgImyzMEXuOssgVD96kTgKdD58ntMEcKJlcDeYRpSN4uSjQr0HIwxq9D4FHfA72IB5+I20mM4KAIu0QzRSCo09nl0TDDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717609705; c=relaxed/simple; bh=enupfRHuA/sUxcPvYiVVg7oNNALRyFrXlotRKy7IvuM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i1cNbuuJULO2rdN5xMhNoDYLGeiizVSj0nde0zYzmX+8fBtgWkatdPiJPiQwrrU8AUheqB+1fXVdz3dCbLhVOrK4r5B9DHJl/ajsEyQAlLVdC3diLbXfqNBP8unOh+d4LiqdopqVqU6+xtZXhgbv34sxg/xI8VLgbQb1R+10t78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q6XGPEKJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q6XGPEKJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E54DC2BD11; Wed, 5 Jun 2024 17:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717609705; bh=enupfRHuA/sUxcPvYiVVg7oNNALRyFrXlotRKy7IvuM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q6XGPEKJV+EC0QMabsGEV9vd0/gyTkTUfF+TAEXj9Jy82MgO8X2lzIXWqIRAyBC86 p4XFyPX0I/WfDCqM65cOTJJ9NtKpl/hvtdUdsUpBcVVWkFc3jG6Q8rAEkBNStkNJs5 EeMBLlqRH+zZaZrNfQwk35LbS5N95a8bjDH9lzLQvjv7h1K8dVURxuxRCT3CuS5mlI wnRXZtwm4GPtEcZMOi8f5BwtzvNtu9FnvxuB9E0f0+/V3OOEXYLQmrnZIKL2mBm75A Cuee7zNrJx1tzlb/W2d4QWFOgOXgEjONB2UVOHmux2fi2SBrWeUwLfey2ouK6lGMGA PlcBGDPnUqH0w== Date: Wed, 5 Jun 2024 18:48:17 +0100 From: Simon Horman To: Serge Semin Cc: Andrew Lunn , Heiner Kallweit , Russell King , Alexandre Torgue , Jose Abreu , Jose Abreu , Vladimir Oltean , Florian Fainelli , Maxime Chevallier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sagar Cheluvegowda , Abhishek Chauhan , Andrew Halaney , Jiawen Wu , Mengyuan Lou , Tomer Maimon , openbmc@lists.ozlabs.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 07/10] net: pcs: xpcs: Add Synopsys DW xPCS platform device driver Message-ID: <20240605174817.GQ791188@kernel.org> References: <20240602143636.5839-1-fancer.lancer@gmail.com> <20240602143636.5839-8-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240602143636.5839-8-fancer.lancer@gmail.com> On Sun, Jun 02, 2024 at 05:36:21PM +0300, Serge Semin wrote: ... > diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c ... > +const struct dev_pm_ops xpcs_plat_pm_ops = { > + SET_RUNTIME_PM_OPS(xpcs_plat_pm_runtime_suspend, > + xpcs_plat_pm_runtime_resume, > + NULL) > +}; nit: xpcs_plat_pm_ops only seems to be used in this file. If so it should probably be static. Flagged by Sparse. ... > +static struct platform_driver xpcs_plat_driver = { > + .probe = xpcs_plat_probe, > + .driver = { > + .name = "dwxpcs", > + .pm = &xpcs_plat_pm_ops, > + .of_match_table = xpcs_of_ids, > + }, > +}; > +module_platform_driver(xpcs_plat_driver); ...