From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 645D4C25B76 for ; Wed, 5 Jun 2024 17:20:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEuII-0004T3-3g; Wed, 05 Jun 2024 13:19:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEuIG-0004Sm-Qk for qemu-devel@nongnu.org; Wed, 05 Jun 2024 13:19:24 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEuID-000308-M8 for qemu-devel@nongnu.org; Wed, 05 Jun 2024 13:19:24 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VvZ0n2vwCz688KN; Thu, 6 Jun 2024 01:18:01 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 1F9351400C8; Thu, 6 Jun 2024 01:19:13 +0800 (CST) Received: from localhost (10.126.172.226) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 5 Jun 2024 18:19:12 +0100 Date: Wed, 5 Jun 2024 18:19:11 +0100 To: Richard Henderson CC: "Michael S. Tsirkin" , , "Peter Maydell" , Igor Mammedov , Ani Sinha Subject: Re: [PULL 36/46] bios-tables-test: Add data for complex numa test (GI, GP etc) Message-ID: <20240605181911.00005f09@Huawei.com> In-Reply-To: <4d097eaf-d555-41a7-8c3f-c2abe8a51ab6@linaro.org> References: <61cbf56ef1c5dd9dbe6bd6625f6c8d2a82c5697f.1717527933.git.mst@redhat.com> <2eefcbdb-ad41-465a-9c14-1dc15bfff94a@linaro.org> <20240605162733.00007d8d@Huawei.com> <3a1c870c-f708-482d-802a-d3230b398c28@linaro.org> <20240605170845.000000dc@huawei.com> <20240605171136.00003879@huawei.com> <4d097eaf-d555-41a7-8c3f-c2abe8a51ab6@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.172.226] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 5 Jun 2024 09:54:16 -0700 Richard Henderson wrote: > On 6/5/24 11:11, Jonathan Cameron wrote: > >>> Sure. By what incantation do I produce a dump? > >> > >> If you still have the /mnt/aml-GHR602 above then either upload that somewhere or > >> iasl -d /mnt/aml-GHR602 > >> should generate you a suitable text file. However generic ports are fairly recent > >> so you may need a newer iasl from acpica-tools to decode. > >> It will moan if it doesn't understand the content. > >> > > make check-qtest-x86_64 is how I get the test to run in the first place. > > Ah, I see, the file is not cleaned up on abort. Yes. End up with a lot of those after a while! > For the record, I attach the dump. Thanks! > > > Alternatively, this 'might' be sufficient if my guess for the problem > > is correct. Thanks! > > > > From 956df037f024783f19b6b00e5e280484380227a0 Mon Sep 17 00:00:00 2001 > > From: Jonathan Cameron > > Date: Wed, 5 Jun 2024 17:01:36 +0100 > > Subject: [PATCH] hw/acpi: Fix big endian host creation of Generic Port > > Affinity Structures > > > > Treating the HID as an integer caused it to get bit reversed > > on big endian hosts running little endian guests. Treat it > > as a character array instead. > > > > Fixes hw/acpi: Generic Port Affinity Structure Support > > Signed-off-by: Jonathan Cameron > > > > --- > > Maybe this is the only problem? I don't have a setup to test > > so any help would be appreciated. > > --- > > include/hw/acpi/acpi_generic_initiator.h | 2 +- > > hw/acpi/acpi_generic_initiator.c | 6 +++++- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/include/hw/acpi/acpi_generic_initiator.h b/include/hw/acpi/acpi_generic_initiator.h > > index 1a899af30f..5baefda33a 100644 > > --- a/include/hw/acpi/acpi_generic_initiator.h > > +++ b/include/hw/acpi/acpi_generic_initiator.h > > @@ -61,7 +61,7 @@ typedef struct PCIDeviceHandle { > > uint16_t bdf; > > }; > > struct { > > - uint64_t hid; > > + char hid[8]; > > uint32_t uid; > > }; > > }; > > diff --git a/hw/acpi/acpi_generic_initiator.c b/hw/acpi/acpi_generic_initiator.c > > index 78b80dcf08..c2fb5ab2ef 100644 > > --- a/hw/acpi/acpi_generic_initiator.c > > +++ b/hw/acpi/acpi_generic_initiator.c > > @@ -150,8 +150,12 @@ build_srat_generic_node_affinity(GArray *table_data, int node, > > build_append_int_noprefix(table_data, handle->bdf, 2); > > build_append_int_noprefix(table_data, 0, 12); > > } else { > > + int i; > > + > > /* Device Handle - ACPI */ > > - build_append_int_noprefix(table_data, handle->hid, 8); > > + for (i = 0; i < sizeof(handle->hid); i++) { > > + build_append_int_noprefix(table_data, handle->hid[i], 1); > > + } > > build_append_int_noprefix(table_data, handle->uid, 4); > > build_append_int_noprefix(table_data, 0, 4); > > } > > Yes, this fixes the abort. > Merge the declaration of i into the for loop? sure. Thanks for testing. Seems it's time I tried to get an emulated s390 setup running if that's practical as two of these in the last year :( Jonathan > > > r~