From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Benjamin Marzinski <bmarzins@redhat.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 2/3] dm: Improve zone resource limits handling
Date: Thu, 6 Jun 2024 06:39:58 +0200 [thread overview]
Message-ID: <20240606043958.GA8331@lst.de> (raw)
In-Reply-To: <90629a40-e45f-490b-bef6-436839d91b92@kernel.org>
On Thu, Jun 06, 2024 at 08:52:32AM +0900, Damien Le Moal wrote:
> Unless you have a better idea, I think we need to pass a queue_limits struct
> pointer to blk_revalidate_disk_zones() -> disk_update_zone_resources(). This
> pointer can be NULL, in which case disk_update_zone_resources() needs to do the
> limit start_update+commit. But if it is not NULL, then
> disk_update_zone_resources() must use the passed limits.
I think the right thing is to simply move the call to dm_revalidate_zones
out of dm_set_zones_restrictions and after the queue_limits_set call
in dm_table_set_restrictions.
next prev parent reply other threads:[~2024-06-06 4:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 7:51 [PATCH v4 0/3] Fix DM zone resource limits stacking Damien Le Moal
2024-06-05 7:51 ` [PATCH v4 1/3] block: Improve checks on zone resource limits Damien Le Moal
2024-06-05 7:54 ` Christoph Hellwig
2024-06-05 17:25 ` Niklas Cassel
2024-06-06 0:06 ` Damien Le Moal
2024-06-06 1:21 ` Niklas Cassel
2024-06-06 2:12 ` Damien Le Moal
2024-06-06 4:41 ` Christoph Hellwig
2024-06-05 7:51 ` [PATCH v4 2/3] dm: Improve zone resource limits handling Damien Le Moal
2024-06-05 7:55 ` Christoph Hellwig
2024-06-05 19:47 ` Benjamin Marzinski
2024-06-05 23:52 ` Damien Le Moal
2024-06-06 4:39 ` Christoph Hellwig [this message]
2024-06-06 5:48 ` Damien Le Moal
2024-06-05 7:51 ` [PATCH v4 3/3] dm: Remove unused macro DM_ZONE_INVALID_WP_OFST Damien Le Moal
2024-06-05 7:55 ` Christoph Hellwig
2024-06-05 19:50 ` Benjamin Marzinski
2024-06-05 12:40 ` [PATCH v4 0/3] Fix DM zone resource limits stacking Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606043958.GA8331@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.