From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>, Gal Pressman <gal@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
nalramli@fastly.com, Carolina Jubran <cjubran@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org (open list:MELLANOX MLX5 core VPI
driver), Naveen Mamindlapalli <naveenm@marvell.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [RFC net-next v4 0/2] mlx5: Add netdev-genl queue stats
Date: Thu, 6 Jun 2024 09:23:53 -0700 [thread overview]
Message-ID: <20240606092353.31908bc1@kernel.org> (raw)
In-Reply-To: <20240604004629.299699-1-jdamato@fastly.com>
On Tue, 4 Jun 2024 00:46:24 +0000 Joe Damato wrote:
> Significant rewrite from v3 and hopefully getting closer to correctly
> exporting per queue stats from mlx5. Please see changelog below for
> detailed changes, especially regarding PTP stats.
>
> Note that my NIC does not seem to support PTP and I couldn't get the
> mlnx-tools mlnx_qos script to work, so I was only able to test the
> following cases:
>
> - device up at booot
> - adjusting queue counts
> - device down (e.g. ip link set dev eth4 down)
>
> Please see the commit message of patch 2/2 for more details on output
> and test cases.
nvidia, please review this
It's less than 200 lines of code, and every time Joe posts a new
version he has to wait a week to get feedback.
prev parent reply other threads:[~2024-06-06 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 0:46 [RFC net-next v4 0/2] mlx5: Add netdev-genl queue stats Joe Damato
2024-06-04 0:46 ` [RFC net-next v4 1/2] net/mlx5e: Add txq to sq stats mapping Joe Damato
2024-06-06 20:13 ` Tariq Toukan
2024-06-04 0:46 ` [RFC net-next v4 2/2] net/mlx5e: Add per queue netdev-genl stats Joe Damato
2024-06-06 20:11 ` Tariq Toukan
2024-06-06 21:54 ` Joe Damato
2024-06-07 0:19 ` Jakub Kicinski
2024-06-07 1:02 ` Joe Damato
2024-06-07 7:53 ` Tariq Toukan
2024-06-11 0:22 ` Jakub Kicinski
2024-06-07 7:40 ` Tariq Toukan
2024-06-07 20:50 ` Joe Damato
2024-06-12 20:13 ` Joe Damato
2024-06-06 16:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606092353.31908bc1@kernel.org \
--to=kuba@kernel.org \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hkelam@marvell.com \
--cc=jdamato@fastly.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nalramli@fastly.com \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.