From: Greg KH <gregkh@linuxfoundation.org>
To: Soumya Khasnis <soumya.khasnis@sony.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
daniel.lezcano@linaro.org, festevam@denx.de, lee@kernel.org,
benjamin.bara@skidata.com, dmitry.osipenko@collabora.com,
ldmldm05@gmail.com, srinavasa.nagaraju@sony.com,
Madhusudan.Bobbili@sony.com, shingo.takeuchi@sony.com,
keita.aihara@sony.com, masaya.takahashi@sony.com
Subject: Re: [PATCH v3] driver core: Add timeout for device shutdown
Date: Thu, 6 Jun 2024 22:52:14 +0200 [thread overview]
Message-ID: <2024060637-imposing-ahoy-b8bb@gregkh> (raw)
In-Reply-To: <20240606085003.GA118950@sony.com>
On Thu, Jun 06, 2024 at 08:50:03AM +0000, Soumya Khasnis wrote:
> The device shutdown callbacks invoked during shutdown/reboot
> are prone to errors depending on the device state or mishandling
> by one or more driver. In order to prevent a device hang in such
> scenarios, we bail out after a timeout while dumping a meaningful
> call trace of the shutdown callback to kernel logs, which blocks
> the shutdown or reboot process.
>
> Signed-off-by: Soumya Khasnis <soumya.khasnis@sony.com>
> Signed-off-by: Srinavasa Nagaraju <Srinavasa.Nagaraju@sony.com>
> ---
> Changes in v3:
> -fix review comments
What ones? In what way? This really doesn't help, sorry. Would you
like to see this type of response if you were to review other people's
code?
> -updated commit message
In what way?
confused,
greg k-h
next prev parent reply other threads:[~2024-06-06 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 8:50 [PATCH v3] driver core: Add timeout for device shutdown Soumya Khasnis
2024-06-06 15:23 ` Daniel Lezcano
2024-06-07 11:37 ` Khasnis Soumya
2024-06-06 20:52 ` Greg KH [this message]
2024-06-07 11:50 ` Khasnis Soumya
2024-06-07 0:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024060637-imposing-ahoy-b8bb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Madhusudan.Bobbili@sony.com \
--cc=benjamin.bara@skidata.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.osipenko@collabora.com \
--cc=festevam@denx.de \
--cc=keita.aihara@sony.com \
--cc=ldmldm05@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masaya.takahashi@sony.com \
--cc=rafael@kernel.org \
--cc=shingo.takeuchi@sony.com \
--cc=soumya.khasnis@sony.com \
--cc=srinavasa.nagaraju@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.