From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991A913C69B; Fri, 7 Jun 2024 08:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717747577; cv=none; b=QKatUUWifn/uTNSvXp+S3DiiJE1PnISy/HG7z/KiCKr7zE6Ymdo+n/stIuyLuOnfmc/6B1h3/Y3IQFYiDuEOqIRerV/cUD8aLf67IGCfqpPDRybvzIgojQZR2Tfxg7OF0FE28k0sLYXFY/Co3UFyKe5JidRdyH1Sg7awaSovAFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717747577; c=relaxed/simple; bh=D+/UALLSv9oy4xrGrHjWW+E2Ia6tzKVJHvFUaGkGlwc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OwiMoYODoGp5ua/dw5uCnvN/2vwxbstHqeFudM1qtnXT+P+JII+4BfO0nnPcR1KBalbV1I0gxp3MwuQoH4ANNPRa8OCHdU4eobYoSF3COWlG7BxZKQDnNEnzD2MGXWiN/9bZ+Uh6083yd9jFqShFyrs6dasEVk8edTCBkTAmH18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PH0J6+8z; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PH0J6+8z" Received: by mail.gandi.net (Postfix) with ESMTPSA id 3A06D1C0007; Fri, 7 Jun 2024 08:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717747571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BFfuVjtrcTLRobaSH0psf6/I1QuxZBKYWSnIuQ5XmGY=; b=PH0J6+8ztUFADaSZDGfHF5vJoDDUoehBQuL0rnhj6Ma8m2WkOuDaQiNIaA7QAPzuAC1Ym9 GoJdsST2eUkSP8+5iY6JrMym0qUGpiy+NqNvGnDi+/L49RlwfebD6AxcnAiQIhiyPo+sPs ajtCZg98h/of8iYKa75/kDuP5ls7hcE1d8j758hYYQ8MpanGim680eb9TxamL8H6JzRxnP gt8wsuEyueFEr94ynXLWrQvXsj+ef5qT1UD4y3ELSK4SGXLaHWnnqFYD2OmJXNu74GMXud afFFmhjBoHAjvKS8ge/I1ku3JNZnqjBXujksJ/hOOc/g1AVw2yxw+zgk106yLg== Date: Fri, 7 Jun 2024 10:06:03 +0200 From: Herve Codina To: Thomas Gleixner Cc: Simon Horman , Sai Krishna Gajula , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v2 10/19] irqdomain: Introduce irq_domain_alloc() and irq_domain_publish() Message-ID: <20240607100603.660efc87@bootlin.com> In-Reply-To: <87v82m0wms.ffs@tglx> References: <20240527161450.326615-1-herve.codina@bootlin.com> <20240527161450.326615-11-herve.codina@bootlin.com> <8734pr5yq1.ffs@tglx> <20240606175258.0e36ea98@bootlin.com> <87v82m0wms.ffs@tglx> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com On Thu, 06 Jun 2024 20:11:23 +0200 Thomas Gleixner wrote: > Herve! > > On Thu, Jun 06 2024 at 17:52, Herve Codina wrote: > > On Wed, 05 Jun 2024 15:02:46 +0200 > > Thomas Gleixner wrote: > >> On Mon, May 27 2024 at 18:14, Herve Codina wrote: > >> > To avoid a window where the domain is published but not yet ready to be > >> > >> I can see the point, but why is this suddenly a problem? There are tons > >> of interrupt chip drivers which have exactly that pattern. > > > > I thing the issue was not triggered because these interrupt chip driver > > are usually builtin compiled and the probe sequence is the linear one > > done at boot time. Consumers/supplier are probe sequentially without any > > parallel execution issues. > > > > In the LAN966x PCI device driver use case, the drivers were built as > > modules. Modules loading and drivers .probe() calls for the irqs supplier > > and irqs consumers are done in parallel. This reveals the race condition. > > So how is that supposed to work? There is clearly a requirement that the > interrupt controller is ready to use when the network driver is probed, no? Yes, EPROBE_DEFER mecanism. The race condition window leads to an other error code instead of the expected EPROBE_DEFER. > > >> Also why is all of this burried in a series which aims to add a network > >> driver and touches the world and some more. If you had sent the two irq > >> domain patches seperately w/o spamming 100 people on CC then this would > >> have been solved long ago. That's documented clearly, no? > > > > Yes, the main idea of the series, as mentioned in the cover letter, is to > > give the big picture of the LAN966x PCI device use case in order to have > > all the impacted subsystems and drivers maintainers be aware of the global > > use case: DT overlay on top of PCI device. > > Of course, the plan is to split this series into smaller ones once parts > > get discussed in the DT overlay on top of PCI use case and reach some kind > > of maturity at least on the way to implement a solution. > > Fair enough. > > > Thomas, do you prefer to have all the IRQ related patches extracted right > > now from this big picture series ? > > I think the interrupt controller problem is completely orthogonal to the > PCI/DT issue. > > So yes, please split them out as preparatory work which is probably also > not that interesting for the PCI/DT/net folks. > Will do that. Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7D89C27C55 for ; Fri, 7 Jun 2024 08:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MD2asPE6VOCnEZCHtaQSeWUWIA5yGudIsQsBAmIzOtw=; b=wFpUgDTnys6CrH BIAaaw3beXRfoh/OfIjEHEROGGUdTJ1UrZL/JNEF2WpBpTQJbpzys9scN6I3t5LXy+U34KCjj8Mkq di03/77hN4YuqyVLugGv+cr/XreOKVoF0oKowRxyRfpZuSeKcqlk5/jrqZomRJt6dxmaTbLkJeSVz io8cvk/9dFFJKvKxd9QAh50Kyb0PlOM5mT+GuX040oemvQq7C5MdtsDSpToatvWBlbsAbjP+jCgzH EKjfge2DvlUBnNi26aPnuyWxhQIZiXQTQN2LXkSTdzKG1+fze3Brrlht0+V8u+mBF6FK7K/yhoyif 6nLvG2NB83VRkvljp/MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFUc7-0000000D3fh-2sJH; Fri, 07 Jun 2024 08:06:19 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFUc4-0000000D3eo-1N6Z for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 08:06:18 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3A06D1C0007; Fri, 7 Jun 2024 08:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717747571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BFfuVjtrcTLRobaSH0psf6/I1QuxZBKYWSnIuQ5XmGY=; b=PH0J6+8ztUFADaSZDGfHF5vJoDDUoehBQuL0rnhj6Ma8m2WkOuDaQiNIaA7QAPzuAC1Ym9 GoJdsST2eUkSP8+5iY6JrMym0qUGpiy+NqNvGnDi+/L49RlwfebD6AxcnAiQIhiyPo+sPs ajtCZg98h/of8iYKa75/kDuP5ls7hcE1d8j758hYYQ8MpanGim680eb9TxamL8H6JzRxnP gt8wsuEyueFEr94ynXLWrQvXsj+ef5qT1UD4y3ELSK4SGXLaHWnnqFYD2OmJXNu74GMXud afFFmhjBoHAjvKS8ge/I1ku3JNZnqjBXujksJ/hOOc/g1AVw2yxw+zgk106yLg== Date: Fri, 7 Jun 2024 10:06:03 +0200 From: Herve Codina To: Thomas Gleixner Cc: Simon Horman , Sai Krishna Gajula , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v2 10/19] irqdomain: Introduce irq_domain_alloc() and irq_domain_publish() Message-ID: <20240607100603.660efc87@bootlin.com> In-Reply-To: <87v82m0wms.ffs@tglx> References: <20240527161450.326615-1-herve.codina@bootlin.com> <20240527161450.326615-11-herve.codina@bootlin.com> <8734pr5yq1.ffs@tglx> <20240606175258.0e36ea98@bootlin.com> <87v82m0wms.ffs@tglx> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240607_010616_807456_151CA4F5 X-CRM114-Status: GOOD ( 28.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwNiBKdW4gMjAyNCAyMDoxMToyMyArMDIwMApUaG9tYXMgR2xlaXhuZXIgPHRnbHhA bGludXRyb25peC5kZT4gd3JvdGU6Cgo+IEhlcnZlIQo+IAo+IE9uIFRodSwgSnVuIDA2IDIwMjQg YXQgMTc6NTIsIEhlcnZlIENvZGluYSB3cm90ZToKPiA+IE9uIFdlZCwgMDUgSnVuIDIwMjQgMTU6 MDI6NDYgKzAyMDAKPiA+IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPiB3cm90 ZTogIAo+ID4+IE9uIE1vbiwgTWF5IDI3IDIwMjQgYXQgMTg6MTQsIEhlcnZlIENvZGluYSB3cm90 ZTogIAo+ID4+ID4gVG8gYXZvaWQgYSB3aW5kb3cgd2hlcmUgdGhlIGRvbWFpbiBpcyBwdWJsaXNo ZWQgYnV0IG5vdCB5ZXQgcmVhZHkgdG8gYmUgICAgCj4gPj4gCj4gPj4gSSBjYW4gc2VlIHRoZSBw b2ludCwgYnV0IHdoeSBpcyB0aGlzIHN1ZGRlbmx5IGEgcHJvYmxlbT8gVGhlcmUgYXJlIHRvbnMK PiA+PiBvZiBpbnRlcnJ1cHQgY2hpcCBkcml2ZXJzIHdoaWNoIGhhdmUgZXhhY3RseSB0aGF0IHBh dHRlcm4uICAKPiA+Cj4gPiBJIHRoaW5nIHRoZSBpc3N1ZSB3YXMgbm90IHRyaWdnZXJlZCBiZWNh dXNlIHRoZXNlIGludGVycnVwdCBjaGlwIGRyaXZlcgo+ID4gYXJlIHVzdWFsbHkgYnVpbHRpbiBj b21waWxlZCBhbmQgdGhlIHByb2JlIHNlcXVlbmNlIGlzIHRoZSBsaW5lYXIgb25lCj4gPiBkb25l IGF0IGJvb3QgdGltZS4gQ29uc3VtZXJzL3N1cHBsaWVyIGFyZSBwcm9iZSBzZXF1ZW50aWFsbHkg d2l0aG91dCBhbnkKPiA+IHBhcmFsbGVsIGV4ZWN1dGlvbiBpc3N1ZXMuCj4gPgo+ID4gSW4gdGhl IExBTjk2NnggUENJIGRldmljZSBkcml2ZXIgdXNlIGNhc2UsIHRoZSBkcml2ZXJzIHdlcmUgYnVp bHQgYXMKPiA+IG1vZHVsZXMuIE1vZHVsZXMgbG9hZGluZyBhbmQgZHJpdmVycyAucHJvYmUoKSBj YWxscyBmb3IgdGhlIGlycXMgc3VwcGxpZXIKPiA+IGFuZCBpcnFzIGNvbnN1bWVycyBhcmUgZG9u ZSBpbiBwYXJhbGxlbC4gVGhpcyByZXZlYWxzIHRoZSByYWNlIGNvbmRpdGlvbi4gIAo+IAo+IFNv IGhvdyBpcyB0aGF0IHN1cHBvc2VkIHRvIHdvcms/IFRoZXJlIGlzIGNsZWFybHkgYSByZXF1aXJl bWVudCB0aGF0IHRoZQo+IGludGVycnVwdCBjb250cm9sbGVyIGlzIHJlYWR5IHRvIHVzZSB3aGVu IHRoZSBuZXR3b3JrIGRyaXZlciBpcyBwcm9iZWQsIG5vPwoKWWVzLCBFUFJPQkVfREVGRVIgbWVj YW5pc20uClRoZSByYWNlIGNvbmRpdGlvbiB3aW5kb3cgbGVhZHMgdG8gYW4gb3RoZXIgZXJyb3Ig Y29kZSBpbnN0ZWFkIG9mIHRoZQpleHBlY3RlZCBFUFJPQkVfREVGRVIuCgo+IAo+ID4+IEFsc28g d2h5IGlzIGFsbCBvZiB0aGlzIGJ1cnJpZWQgaW4gYSBzZXJpZXMgd2hpY2ggYWltcyB0byBhZGQg YSBuZXR3b3JrCj4gPj4gZHJpdmVyIGFuZCB0b3VjaGVzIHRoZSB3b3JsZCBhbmQgc29tZSBtb3Jl LiBJZiB5b3UgaGFkIHNlbnQgdGhlIHR3byBpcnEKPiA+PiBkb21haW4gcGF0Y2hlcyBzZXBlcmF0 ZWx5IHcvbyBzcGFtbWluZyAxMDAgcGVvcGxlIG9uIENDIHRoZW4gdGhpcyB3b3VsZAo+ID4+IGhh dmUgYmVlbiBzb2x2ZWQgbG9uZyBhZ28uIFRoYXQncyBkb2N1bWVudGVkIGNsZWFybHksIG5vPyAg Cj4gPgo+ID4gWWVzLCB0aGUgbWFpbiBpZGVhIG9mIHRoZSBzZXJpZXMsIGFzIG1lbnRpb25lZCBp biB0aGUgY292ZXIgbGV0dGVyLCBpcyB0bwo+ID4gZ2l2ZSB0aGUgYmlnIHBpY3R1cmUgb2YgdGhl IExBTjk2NnggUENJIGRldmljZSB1c2UgY2FzZSBpbiBvcmRlciB0byBoYXZlCj4gPiBhbGwgdGhl IGltcGFjdGVkIHN1YnN5c3RlbXMgYW5kIGRyaXZlcnMgbWFpbnRhaW5lcnMgYmUgYXdhcmUgb2Yg dGhlIGdsb2JhbAo+ID4gdXNlIGNhc2U6IERUIG92ZXJsYXkgb24gdG9wIG9mIFBDSSBkZXZpY2Uu Cj4gPiBPZiBjb3Vyc2UsIHRoZSBwbGFuIGlzIHRvIHNwbGl0IHRoaXMgc2VyaWVzIGludG8gc21h bGxlciBvbmVzIG9uY2UgcGFydHMKPiA+IGdldCBkaXNjdXNzZWQgaW4gdGhlIERUIG92ZXJsYXkg b24gdG9wIG9mIFBDSSB1c2UgY2FzZSBhbmQgcmVhY2ggc29tZSBraW5kCj4gPiBvZiBtYXR1cml0 eSBhdCBsZWFzdCBvbiB0aGUgd2F5IHRvIGltcGxlbWVudCBhIHNvbHV0aW9uLiAgCj4gCj4gRmFp ciBlbm91Z2guCj4gCj4gPiBUaG9tYXMsIGRvIHlvdSBwcmVmZXIgdG8gaGF2ZSBhbGwgdGhlIElS USByZWxhdGVkIHBhdGNoZXMgZXh0cmFjdGVkIHJpZ2h0Cj4gPiBub3cgZnJvbSB0aGlzIGJpZyBw aWN0dXJlIHNlcmllcyA/ICAKPiAKPiBJIHRoaW5rIHRoZSBpbnRlcnJ1cHQgY29udHJvbGxlciBw cm9ibGVtIGlzIGNvbXBsZXRlbHkgb3J0aG9nb25hbCB0byB0aGUKPiBQQ0kvRFQgaXNzdWUuCj4g Cj4gU28geWVzLCBwbGVhc2Ugc3BsaXQgdGhlbSBvdXQgYXMgcHJlcGFyYXRvcnkgd29yayB3aGlj aCBpcyBwcm9iYWJseSBhbHNvCj4gbm90IHRoYXQgaW50ZXJlc3RpbmcgZm9yIHRoZSBQQ0kvRFQv bmV0IGZvbGtzLgo+IAoKV2lsbCBkbyB0aGF0LgoKQmVzdCByZWdhcmRzLApIZXJ2w6kKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK