Re: [PATCH V2 1/9] PCI: Introduce PCIe TPH support framework

[Bjorn Helgaas <helgaas@kernel.org>]

On Fri, May 31, 2024 at 04:38:33PM -0500, Wei Huang wrote:
> This patch implements the framework for PCIe TPH support. It introduces
> tph.c source file, along with CONFIG_PCIE_TPH, to Linux PCIe subsystem.
> A new member, named tph_cap, is also introduced in pci_dev to cache TPH
> capability offset.

s/This patch implements/Implement/
s/It introduces/Introduce/
s/is also introduced/Add tph_cap .../

https://chris.beams.io/posts/git-commit/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.9#n94

> +	  This option adds support for PCIE TLP Processing Hints (TPH).
> +	  TPH allows endpoint devices to provide optimization hints, such as
> +	  desired caching behavior, for requests that target memory space.
> +	  These hints, called steering tags, can empower the system hardware
> +	  to optimize the utilization of platform resources.

s/PCIE TLP/PCIe TLP/ to match context.

> +++ b/drivers/pci/pcie/tph.c

> +#define pr_fmt(fmt) "TPH: " fmt
> +#define dev_fmt pr_fmt

Add when used.

> +void pcie_tph_init(struct pci_dev *dev)
> +{
> +	dev->tph_cap = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_TPH);
> +}
> +

  $ git am m/v2_20240531_wei_huang2_pcie_tph_and_cache_direct_injection_support.mbx
  Applying: PCI: Introduce PCIe TPH support framework
  .git/rebase-apply/patch:88: new blank line at EOF.
  +
  warning: 1 line adds whitespace errors.