Re: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool()

[kernel test robot <lkp@intel.com>]

Hi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on joro-iommu/next]
[also build test WARNING on linus/master v6.10-rc2 next-20240607]
[cannot apply to xen-tip/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/mhkelley58-gmail-com/swiotlb-Reduce-calls-to-swiotlb_find_pool/20240607-114732
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
patch link:    https://lore.kernel.org/r/20240607031421.182589-1-mhklinux%40outlook.com
patch subject: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool()
config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240607/202406071654.vpgXWObk-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406071654.vpgXWObk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406071654.vpgXWObk-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/dma/swiotlb.c:1509: warning: Function parameter or struct member 'pool' not described in 'swiotlb_del_transient'


vim +1509 kernel/dma/swiotlb.c

79636caad3618e Petr Tesarik   2023-08-01  1496  
79636caad3618e Petr Tesarik   2023-08-01  1497  /**
79636caad3618e Petr Tesarik   2023-08-01  1498   * swiotlb_del_transient() - delete a transient memory pool
79636caad3618e Petr Tesarik   2023-08-01  1499   * @dev:	Device which mapped the buffer.
79636caad3618e Petr Tesarik   2023-08-01  1500   * @tlb_addr:	Physical address within a bounce buffer.
79636caad3618e Petr Tesarik   2023-08-01  1501   *
79636caad3618e Petr Tesarik   2023-08-01  1502   * Check whether the address belongs to a transient SWIOTLB memory pool.
79636caad3618e Petr Tesarik   2023-08-01  1503   * If yes, then delete the pool.
79636caad3618e Petr Tesarik   2023-08-01  1504   *
79636caad3618e Petr Tesarik   2023-08-01  1505   * Return: %true if @tlb_addr belonged to a transient pool that was released.
79636caad3618e Petr Tesarik   2023-08-01  1506   */
e55c3fdc1c0850 Michael Kelley 2024-06-06  1507  static bool swiotlb_del_transient(struct device *dev, phys_addr_t tlb_addr,
e55c3fdc1c0850 Michael Kelley 2024-06-06  1508  				  struct io_tlb_pool *pool)
79636caad3618e Petr Tesarik   2023-08-01 @1509  {
79636caad3618e Petr Tesarik   2023-08-01  1510  	if (!pool->transient)
79636caad3618e Petr Tesarik   2023-08-01  1511  		return false;
79636caad3618e Petr Tesarik   2023-08-01  1512  
79636caad3618e Petr Tesarik   2023-08-01  1513  	dec_used(dev->dma_io_tlb_mem, pool->nslabs);
79636caad3618e Petr Tesarik   2023-08-01  1514  	swiotlb_del_pool(dev, pool);
02e765697038c5 ZhangPeng      2024-01-09  1515  	dec_transient_used(dev->dma_io_tlb_mem, pool->nslabs);
79636caad3618e Petr Tesarik   2023-08-01  1516  	return true;
79636caad3618e Petr Tesarik   2023-08-01  1517  }
79636caad3618e Petr Tesarik   2023-08-01  1518  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki