All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 1/4] __attribute__: trace2_region_enter_printf() is like "printf"
Date: Sat,  8 Jun 2024 11:37:44 -0700	[thread overview]
Message-ID: <20240608183747.2084294-2-gitster@pobox.com> (raw)
In-Reply-To: <20240608183747.2084294-1-gitster@pobox.com>

The last part of the parameter list the function takes is like
parameters to printf. mark it as such.

An existing call that formats a value of type size_t using "%d" was
found by the compiler with the help with this annotation; fix it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 run-command.c | 3 ++-
 trace2.h      | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/run-command.c b/run-command.c
index 1b821042b4..ec2c12e98b 100644
--- a/run-command.c
+++ b/run-command.c
@@ -1753,7 +1753,8 @@ void run_processes_parallel(const struct run_process_parallel_opts *opts)
 
 	if (do_trace2)
 		trace2_region_enter_printf(tr2_category, tr2_label, NULL,
-					   "max:%d", opts->processes);
+					   "max:%"PRIuMAX,
+					   (uintmax_t)opts->processes);
 
 	pp_init(&pp, opts, &pp_sig);
 	while (1) {
diff --git a/trace2.h b/trace2.h
index 1f0669bbd2..19e04bf040 100644
--- a/trace2.h
+++ b/trace2.h
@@ -390,6 +390,7 @@ void trace2_region_enter_printf_va_fl(const char *file, int line,
 	trace2_region_enter_printf_va_fl(__FILE__, __LINE__, (category), \
 					 (label), (repo), (fmt), (ap))
 
+__attribute__((format (printf, 6, 7)))
 void trace2_region_enter_printf_fl(const char *file, int line,
 				   const char *category, const char *label,
 				   const struct repository *repo,
-- 
2.45.2-445-g1b76f06508


  reply	other threads:[~2024-06-08 18:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-08 18:37 [PATCH 0/4] varargs functions with __attributes__(()) Junio C Hamano
2024-06-08 18:37 ` Junio C Hamano [this message]
2024-06-10  7:01   ` [PATCH 1/4] __attribute__: trace2_region_enter_printf() is like "printf" Patrick Steinhardt
2024-06-10 16:15     ` Junio C Hamano
2024-06-08 18:37 ` [PATCH 2/4] __attribute__: remove redundant attribute declaration for git_die_config() Junio C Hamano
2024-06-08 18:37 ` [PATCH 3/4] __attribute__: mark some functions with LAST_ARG_MUST_BE_NULL Junio C Hamano
2024-06-08 18:37 ` [PATCH 4/4] __attribute__: add a few missing format attributes Junio C Hamano
2024-06-11  8:17 ` [PATCH 0/4] varargs functions with __attributes__(()) Jeff King
2024-06-11 15:17   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240608183747.2084294-2-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.