From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Subject: [PATCH v4 22/26] media: mc: Maintain a list of open file handles in a media device
Date: Mon, 10 Jun 2024 13:05:26 +0300 [thread overview]
Message-ID: <20240610100530.1107771-23-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20240610100530.1107771-1-sakari.ailus@linux.intel.com>
The list of file handles is needed to deliver media events as well as for
other purposes in the future.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/mc/mc-device.c | 19 ++++++++++++++++++-
drivers/media/mc/mc-devnode.c | 2 +-
include/media/media-devnode.h | 4 +++-
3 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
index a9505ab4412d..46d1b0c9d8be 100644
--- a/drivers/media/mc/mc-device.c
+++ b/drivers/media/mc/mc-device.c
@@ -45,8 +45,9 @@ static inline void __user *media_get_uptr(__u64 arg)
return (void __user *)(uintptr_t)arg;
}
-static int media_device_open(struct file *filp)
+static int media_device_open(struct media_devnode *devnode, struct file *filp)
{
+ struct media_device *mdev = to_media_device(devnode);
struct media_device_fh *fh;
fh = kzalloc(sizeof(*fh), GFP_KERNEL);
@@ -55,13 +56,23 @@ static int media_device_open(struct file *filp)
filp->private_data = &fh->fh;
+ spin_lock_irq(&mdev->fh_list_lock);
+ list_add(&fh->mdev_list, &mdev->fh_list);
+ spin_unlock_irq(&mdev->fh_list_lock);
+
return 0;
}
static int media_device_close(struct file *filp)
{
+ struct media_devnode *devnode = media_devnode_data(filp);
+ struct media_device *mdev = to_media_device(devnode);
struct media_device_fh *fh = media_device_fh(filp);
+ spin_lock_irq(&mdev->fh_list_lock);
+ list_del(&fh->mdev_list);
+ spin_unlock_irq(&mdev->fh_list_lock);
+
kfree(fh);
return 0;
@@ -769,11 +780,13 @@ void media_device_init(struct media_device *mdev)
INIT_LIST_HEAD(&mdev->pads);
INIT_LIST_HEAD(&mdev->links);
INIT_LIST_HEAD(&mdev->entity_notify);
+ INIT_LIST_HEAD(&mdev->fh_list);
mutex_init(&mdev->req_queue_mutex);
mutex_init(&mdev->graph_mutex);
ida_init(&mdev->entity_internal_idx);
atomic_set(&mdev->request_id, 0);
+ spin_lock_init(&mdev->fh_list_lock);
mdev->devnode.release = media_device_release;
media_devnode_init(&mdev->devnode);
@@ -830,6 +843,10 @@ void media_device_unregister(struct media_device *mdev)
if (!media_devnode_is_registered(&mdev->devnode))
return;
+ spin_lock_irq(&mdev->fh_list_lock);
+ list_del_init(&mdev->fh_list);
+ spin_unlock_irq(&mdev->fh_list_lock);
+
device_remove_file(&mdev->devnode.dev, &dev_attr_model);
dev_dbg(mdev->dev, "Media device unregistering\n");
media_devnode_unregister(&mdev->devnode);
diff --git a/drivers/media/mc/mc-devnode.c b/drivers/media/mc/mc-devnode.c
index 26491daaba96..617156963911 100644
--- a/drivers/media/mc/mc-devnode.c
+++ b/drivers/media/mc/mc-devnode.c
@@ -154,7 +154,7 @@ static int media_open(struct inode *inode, struct file *filp)
get_device(&devnode->dev);
mutex_unlock(&media_devnode_lock);
- ret = devnode->fops->open(filp);
+ ret = devnode->fops->open(devnode, filp);
if (ret) {
put_device(&devnode->dev);
return ret;
diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h
index e4e8552598eb..898fa67ca090 100644
--- a/include/media/media-devnode.h
+++ b/include/media/media-devnode.h
@@ -21,6 +21,8 @@
#include <linux/device.h>
#include <linux/cdev.h>
+struct media_devnode;
+
/*
* Flag to mark the media_devnode struct as registered. Drivers must not touch
* this flag directly, it will be set and cleared by media_devnode_register and
@@ -49,7 +51,7 @@ struct media_file_operations {
__poll_t (*poll) (struct file *, struct poll_table_struct *);
long (*ioctl) (struct file *, unsigned int, unsigned long);
long (*compat_ioctl) (struct file *, unsigned int, unsigned long);
- int (*open) (struct file *);
+ int (*open) (struct media_devnode *, struct file *);
int (*release) (struct file *);
};
--
2.39.2
next prev parent reply other threads:[~2024-06-10 10:05 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 10:05 [PATCH v4 00/26] Media device lifetime management Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 01/26] Revert "[media] media: fix media devnode ioctl/syscall and unregister race" Sakari Ailus
2024-06-27 6:53 ` Hans Verkuil
2024-06-27 7:04 ` Sakari Ailus
2024-06-27 7:15 ` Hans Verkuil
2024-06-10 10:05 ` [PATCH v4 02/26] Revert "media: utilize new cdev_device_add helper function" Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 03/26] Revert "[media] media: fix use-after-free in cdev_put() when app exits after driver unbind" Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 04/26] media: mc, cec: Make use of cdev_device_add() again Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 05/26] Revert "[media] media-device: dynamically allocate struct media_devnode" Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 06/26] media: mc: Drop nop release callback Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 07/26] media: mc: Drop media_dev description from struct media_devnode Sakari Ailus
2024-06-17 9:02 ` Hans Verkuil
2024-06-17 11:43 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 08/26] media: mc: Do not call cdev_device_del() if cdev_device_add() fails Sakari Ailus
2024-06-17 9:13 ` Hans Verkuil
2024-06-17 12:15 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 09/26] media: mc: Delete character device early Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 10/26] media: mc: Clear minor number reservation at unregistration time Sakari Ailus
2024-06-27 6:43 ` Hans Verkuil
2024-06-27 6:58 ` Sakari Ailus
2024-06-27 7:10 ` Sakari Ailus
2024-06-27 7:22 ` Hans Verkuil
2025-08-22 8:05 ` Hans Verkuil
2024-06-10 10:05 ` [PATCH v4 11/26] media: mc: Split initialising and adding media devnode Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 12/26] media: mc: Shuffle functions around Sakari Ailus
2024-06-17 9:41 ` Hans Verkuil
2024-06-17 17:59 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 13/26] media: mc: Initialise media devnode in media_device_init() Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 14/26] media: mc: Refcount the media device Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 15/26] media: v4l: Acquire a reference to the media device for every video device Sakari Ailus
2024-06-17 9:39 ` Hans Verkuil
2024-06-10 10:05 ` [PATCH v4 16/26] media: mc: Postpone graph object removal until free Sakari Ailus
2024-06-17 9:44 ` Hans Verkuil
2024-06-10 10:05 ` [PATCH v4 17/26] media: omap3isp: Release the isp device struct by media device callback Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 18/26] media: ipu3-cio2: Release the cio2 device context " Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 19/26] media: vimc: Release resources on media device release Sakari Ailus
2024-06-17 9:49 ` Hans Verkuil
2024-06-17 10:09 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 20/26] media: Documentation: Document how Media device resources are released Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 21/26] media: mc: Add per-file-handle data support Sakari Ailus
2024-06-10 10:05 ` Sakari Ailus [this message]
2024-06-17 9:57 ` [PATCH v4 22/26] media: mc: Maintain a list of open file handles in a media device Hans Verkuil
2024-06-17 17:46 ` Sakari Ailus
2024-06-18 5:35 ` Hans Verkuil
2024-06-18 6:27 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 23/26] media: mc: Implement best effort media device removal safety sans refcount Sakari Ailus
2024-06-17 11:54 ` Hans Verkuil
2024-06-17 20:28 ` Sakari Ailus
2024-06-18 10:33 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 24/26] media: mc: Warn about drivers not releasing media device safely Sakari Ailus
2024-06-17 10:40 ` Hans Verkuil
2024-06-17 17:59 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 25/26] media: mc: Enforce one-time registration Sakari Ailus
2024-06-17 10:42 ` Hans Verkuil
2024-06-18 6:39 ` Sakari Ailus
2024-06-10 10:05 ` [PATCH v4 26/26] media: Documentation: Document media device memory safety helper Sakari Ailus
2024-06-17 11:55 ` [PATCH v4 00/26] Media device lifetime management Hans Verkuil
2024-06-18 10:30 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610100530.1107771-23-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.