From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Dan Jurgens <danielj@nvidia.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"xuanzhuo@linux.alibaba.com" <xuanzhuo@linux.alibaba.com>,
"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"abeni@redhat.com" <abeni@redhat.com>,
Parav Pandit <parav@nvidia.com>
Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters
Date: Mon, 10 Jun 2024 10:57:17 -0700 [thread overview]
Message-ID: <20240610105717.7fbb1caa@kernel.org> (raw)
In-Reply-To: <CAL+tcoDkpZva=aStFKWTO6_8VK2iu9CeSeW2aeC+2QTXR2nD=Q@mail.gmail.com>
On Sat, 8 Jun 2024 08:41:44 +0800 Jason Xing wrote:
> > > Sorry to revive this thread. I wonder why not use this patch like mlnx driver
> > > does instead of adding statistics into the yaml file? Are we gradually using or
> > > adding more fields into the yaml file to replace the 'ethtool -S' command?
> > >
> >
> > It's trivial to have the stats in ethtool as well. But I noticed
> > the stats series intentionally removed some stats from ethtool. So
> > I didn't put it both places.
>
> Thank you for the reply. I thought there was some particular reason
> :-)
Yes, we don't want duplication. We have a long standing (and
documented) policy against duplicating normal stats in custom stat
APIs, otherwise vendors pile everything into the custom stats.
next prev parent reply other threads:[~2024-06-10 17:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 14:25 [PATCH net-next] virtio_net: Add TX stop and wake counters Daniel Jurgens
2024-01-30 14:58 ` Michael S. Tsirkin
2024-01-30 15:40 ` Daniel Jurgens
2024-01-30 15:41 ` Michael S. Tsirkin
2024-01-30 15:50 ` Daniel Jurgens
2024-01-30 15:53 ` Michael S. Tsirkin
2024-01-30 17:33 ` Daniel Jurgens
2024-01-31 2:54 ` Jason Xing
2024-02-02 4:21 ` Jakub Kicinski
2024-02-02 6:52 ` Jason Xing
2024-02-02 16:01 ` Jakub Kicinski
2024-02-02 16:46 ` Daniel Jurgens
2024-02-02 17:38 ` Jakub Kicinski
2024-06-07 9:16 ` Jason Xing
2024-06-07 12:36 ` Dan Jurgens
2024-06-08 0:41 ` Jason Xing
2024-06-10 17:57 ` Jakub Kicinski [this message]
2024-06-11 2:05 ` Jason Xing
2024-02-04 1:20 ` Jason Wang
2024-02-04 12:39 ` Michael S. Tsirkin
2024-02-05 1:45 ` Jason Wang
2024-02-07 20:21 ` Michael S. Tsirkin
2024-02-07 19:38 ` Daniel Jurgens
2024-02-07 20:19 ` Michael S. Tsirkin
2024-02-07 20:59 ` Daniel Jurgens
2024-02-20 18:02 ` Dan Jurgens
2024-02-20 18:05 ` Michael S. Tsirkin
2024-02-20 22:27 ` Jakub Kicinski
2024-01-30 15:16 ` Heng Qi
2024-01-30 15:43 ` Daniel Jurgens
2024-01-30 15:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610105717.7fbb1caa@kernel.org \
--to=kuba@kernel.org \
--cc=abeni@redhat.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kerneljasonxing@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.