All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>, Song Liu <song@kernel.org>,
	Yu Kuai <yukuai3@huawei.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Ira Weiny <ira.weiny@intel.com>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
	linux-raid@vger.kernel.org, nvdimm@lists.linux.dev,
	linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
	Bart Van Assche <bvanassche@acm.org>,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH 02/11] block: remove the unused BIP_{CTRL,DISK}_NOCHECK flags
Date: Mon, 10 Jun 2024 13:51:18 +0200	[thread overview]
Message-ID: <20240610115118.GA19227@lst.de> (raw)
In-Reply-To: <yq1le3d3ua9.fsf@ca-mkp.ca.oracle.com>

On Mon, Jun 10, 2024 at 07:48:52AM -0400, Martin K. Petersen wrote:
> Fundamentally, the biggest problem we had with the original
> implementation was that the "integrity profile" was static on a per
> controller+device basis. The purpose of 1.1 was to make sure that how to
> handle integrity metadata was a per-I/O decision with what to check and
> how to do it driven by whichever entity attached the PI. As opposed to
> being inferred by controllers and targets (through INQUIRY snooping,
> etc.).
> 
> We can add the flags back as part of the io_uring series but it does
> seem like unnecessary churn to remove things in one release only to add
> them back in the next (I'm assuming passthrough will be in 6.12).

I can just keep the flags in, they aren't really in the way of anything
else here.  That being said, if you want opt-in aren't they the wrong
polarity anyway?


  reply	other threads:[~2024-06-10 11:51 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  5:58 move integrity settings to queue_limits v2 Christoph Hellwig
2024-06-07  5:58 ` [PATCH 01/11] dm-integrity: use the nop integrity profile Christoph Hellwig
2024-06-07  6:10   ` Hannes Reinecke
2024-06-07  5:58 ` [PATCH 02/11] block: remove the unused BIP_{CTRL,DISK}_NOCHECK flags Christoph Hellwig
2024-06-07  6:10   ` Hannes Reinecke
2024-06-10 11:48   ` Martin K. Petersen
2024-06-10 11:51     ` Christoph Hellwig [this message]
2024-06-11 20:02       ` Martin K. Petersen
2024-06-12  3:57         ` Christoph Hellwig
2024-06-07  5:58 ` [PATCH 03/11] block: remove the BIP_IP_CHECKSUM flag Christoph Hellwig
2024-06-07  6:11   ` Hannes Reinecke
2024-06-10 11:56   ` Martin K. Petersen
2024-06-10 11:57     ` Christoph Hellwig
2024-06-10 12:19       ` Martin K. Petersen
2024-06-10 12:24         ` Christoph Hellwig
2024-06-11 19:51           ` Martin K. Petersen
2024-06-12  3:51             ` Christoph Hellwig
2024-06-12 17:27               ` Martin K. Petersen
2024-06-13  5:35                 ` Christoph Hellwig
2024-06-14  0:57                   ` Martin K. Petersen
2024-06-14  3:16                     ` Christoph Hellwig
2024-06-07  5:58 ` [PATCH 04/11] block: remove the blk_integrity_profile structure Christoph Hellwig
2024-06-07  6:15   ` Hannes Reinecke
2024-06-07 18:31   ` Kanchan Joshi
2024-06-08  5:08     ` Christoph Hellwig
2024-06-10 12:00   ` Martin K. Petersen
2024-06-07  5:58 ` [PATCH 05/11] block: remove the blk_flush_integrity call in blk_integrity_unregister Christoph Hellwig
2024-06-07  6:16   ` Hannes Reinecke
2024-06-10 12:01   ` Martin K. Petersen
2024-06-07  5:59 ` [PATCH 06/11] block: factor out flag_{store,show} helper for integrity Christoph Hellwig
2024-06-07  6:16   ` Hannes Reinecke
2024-06-10 12:01   ` Martin K. Petersen
2024-06-07  5:59 ` [PATCH 07/11] block: use kstrtoul in flag_store Christoph Hellwig
2024-06-07  6:17   ` Hannes Reinecke
2024-06-10 12:05   ` Martin K. Petersen
2024-06-07  5:59 ` [PATCH 08/11] block: don't require stable pages for non-PI metadata Christoph Hellwig
2024-06-07  6:17   ` Hannes Reinecke
2024-06-10 12:04   ` Martin K. Petersen
2024-06-07  5:59 ` [PATCH 09/11] block: bypass the STABLE_WRITES flag for protection information Christoph Hellwig
2024-06-07  6:20   ` Hannes Reinecke
2024-06-10 12:02   ` Martin K. Petersen
2024-06-07  5:59 ` [PATCH 10/11] block: invert the BLK_INTEGRITY_{GENERATE,VERIFY} flags Christoph Hellwig
2024-06-07  6:21   ` Hannes Reinecke
2024-06-07  5:59 ` [PATCH 11/11] block: move integrity information into queue_limits Christoph Hellwig
2024-06-07  6:29   ` Hannes Reinecke
2024-06-07  6:32     ` Christoph Hellwig
2024-06-07  7:31       ` Hannes Reinecke
2024-06-07  7:35     ` Hannes Reinecke
2024-06-07 14:52       ` Christoph Hellwig
2024-06-07 15:42 ` move integrity settings to queue_limits v2 Mike Snitzer
2024-06-07 16:50   ` Mikulas Patocka
2024-06-08  5:10   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610115118.GA19227@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=ira.weiny@intel.com \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=sagi@grimberg.me \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=vishal.l.verma@intel.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.