All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Mads Ynddal" <mads@ynddal.dk>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/5] trace: Remove and forbid newline characters in event format
Date: Mon, 10 Jun 2024 13:05:33 -0400	[thread overview]
Message-ID: <20240610170533.GA343470@fedora.redhat.com> (raw)
In-Reply-To: <20240606103943.79116-1-philmd@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Thu, Jun 06, 2024 at 12:39:38PM +0200, Philippe Mathieu-Daudé wrote:
> Trace events aren't designed to be multi-lines.
> Few format use the newline character: remove it
> and forbid further uses.
> 
> Philippe Mathieu-Daudé (5):
>   backends/tpm: Remove newline character in trace event
>   hw/sh4: Remove newline character in trace events
>   hw/usb: Remove newline character in trace events
>   hw/vfio: Remove newline character in trace events
>   tracetool: Forbid newline character in event format
> 
>  backends/tpm/tpm_util.c       | 5 +++--
>  backends/tpm/trace-events     | 3 ++-
>  hw/sh4/trace-events           | 4 ++--
>  hw/usb/trace-events           | 6 +++---
>  hw/vfio/trace-events          | 4 ++--
>  scripts/tracetool/__init__.py | 2 ++
>  6 files changed, 14 insertions(+), 10 deletions(-)
> 
> -- 
> 2.41.0
> 

Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2024-06-10 17:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 10:39 [PATCH 0/5] trace: Remove and forbid newline characters in event format Philippe Mathieu-Daudé
2024-06-06 10:39 ` [PATCH 1/5] backends/tpm: Remove newline character in trace event Philippe Mathieu-Daudé
2024-06-06 11:20   ` Daniel P. Berrangé
2024-06-07 15:15   ` Stefan Berger
2024-06-06 10:39 ` [PATCH 2/5] hw/sh4: Remove newline character in trace events Philippe Mathieu-Daudé
2024-06-06 11:21   ` Daniel P. Berrangé
2024-06-06 10:39 ` [PATCH 3/5] hw/usb: " Philippe Mathieu-Daudé
2024-06-06 11:21   ` Daniel P. Berrangé
2024-06-06 10:39 ` [PATCH 4/5] hw/vfio: " Philippe Mathieu-Daudé
2024-06-06 11:22   ` Daniel P. Berrangé
2024-06-06 10:39 ` [PATCH 5/5] tracetool: Forbid newline character in event format Philippe Mathieu-Daudé
2024-06-06 11:22   ` Daniel P. Berrangé
2024-06-07 10:46 ` [PATCH 0/5] trace: Remove and forbid newline characters " Mads Ynddal
2024-06-10 17:05 ` Stefan Hajnoczi [this message]
2024-06-10 17:59   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610170533.GA343470@fedora.redhat.com \
    --to=stefanha@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=mads@ynddal.dk \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.