All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Johannes Thumshirn <jth@kernel.org>
Cc: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	JohnnesThumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 3/3] btrfs: split RAID stripes on deletion
Date: Mon, 10 Jun 2024 15:45:15 -0400	[thread overview]
Message-ID: <20240610194515.GC235772@perftesting> (raw)
In-Reply-To: <20240610-b4-rst-updates-v1-3-179c1eec08f2@kernel.org>

On Mon, Jun 10, 2024 at 10:40:27AM +0200, Johannes Thumshirn wrote:
> From: JohnnesThumshirn <johannes.thumshirn@wdc.com>
> 
> The current RAID stripe code assumes, that we will always remove a
> whole stripe entry.
> 
> But ff we're only removing a part of a RAID stripe we're hitting the
> ASSERT()ion checking for this condition.
> 
> Instead of assuming the complete deletion of a RAID stripe, split the
> stripe if we need to.
> 
> Signed-off-by: Johnnes Thumshirn <johannes.thumshirn@wdc.com>

I'd like a selftest for this helper, should be relatively straightforward to do,
just to test edgecases and such.  Thanks,

Josef

  reply	other threads:[~2024-06-10 19:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  8:40 [PATCH 0/3] btrfs: rst: updates for RAID stripe tree Johannes Thumshirn
2024-06-10  8:40 ` [PATCH 1/3] btrfs: rst: remove encoding field from stripe_extent Johannes Thumshirn
2024-06-11 14:36   ` David Sterba
2024-06-11 16:33     ` Johannes Thumshirn
2024-06-13 21:23       ` David Sterba
2024-06-14  9:36         ` Johannes Thumshirn
2024-06-16 18:19           ` David Sterba
2024-06-17  6:27   ` Qu Wenruo
2024-06-10  8:40 ` [PATCH 2/3] btrfs: replace stripe extents Johannes Thumshirn
2024-06-10 19:43   ` Josef Bacik
2024-06-11  6:27     ` Johannes Thumshirn
2024-06-10  8:40 ` [PATCH 3/3] btrfs: split RAID stripes on deletion Johannes Thumshirn
2024-06-10 19:45   ` Josef Bacik [this message]
2024-06-11  6:39     ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610194515.GC235772@perftesting \
    --to=josef@toxicpanda.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=jth@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.