From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chandan Babu R <chandanbabu@kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: allow unlinked symlinks and dirs with zero size
Date: Mon, 10 Jun 2024 23:07:24 -0700 [thread overview]
Message-ID: <20240611060724.GX52987@frogsfrogsfrogs> (raw)
In-Reply-To: <ZmfXmebrxnQy3OWI@infradead.org>
On Mon, Jun 10, 2024 at 09:50:33PM -0700, Christoph Hellwig wrote:
> On Mon, Jun 10, 2024 at 02:07:23PM -0700, Darrick J. Wong wrote:
> > It turns out that even this is still buggy because directories that are
> > being inactivated (e.g. after repair has replaced the contents) can have
> > zero isize. Sooo I'll have a new patch in a day or two.
>
> Isn't that what this patch checks for? Or do you mean inactivated
> with non-zero nlink?
Nah, there's another verifier check elsewhere that also trips when
di-size == 0.
> Btw, it might make sense to add a helper or local variable to check
> for an unlinked dinode instead of open coding the v1 check twice in
> this function.
Maybe? But the logic is slightly different, isn't it? I'll have a
look in the morning.
--D
prev parent reply other threads:[~2024-06-11 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 16:12 [PATCH] xfs: allow unlinked symlinks and dirs with zero size Darrick J. Wong
2024-06-09 6:33 ` Christoph Hellwig
2024-06-10 21:07 ` Darrick J. Wong
2024-06-11 4:50 ` Christoph Hellwig
2024-06-11 6:07 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611060724.GX52987@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.