From: "Luis Henriques (SUSE)" <luis.henriques@linux.dev>
To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org,
"Luis Henriques (SUSE)" <luis.henriques@linux.dev>
Subject: [PATCH 1/2] e2fsck: don't skip checks if the orphan file is present in the filesystem
Date: Tue, 11 Jun 2024 15:27:03 +0100 [thread overview]
Message-ID: <20240611142704.14307-2-luis.henriques@linux.dev> (raw)
In-Reply-To: <20240611142704.14307-1-luis.henriques@linux.dev>
If the filesystem supports the orphan file feature and that file is present
then don't skip the filesystem checks as that file may need to be cleaned
up.
Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
---
e2fsck/unix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/e2fsck/unix.c b/e2fsck/unix.c
index de20b216dde0..7768f0ed7c4e 100644
--- a/e2fsck/unix.c
+++ b/e2fsck/unix.c
@@ -371,6 +371,10 @@ static void check_if_skip(e2fsck_t ctx)
if (ctx->options & E2F_OPT_JOURNAL_ONLY)
goto skip;
+ if (ext2fs_has_feature_orphan_file(fs->super) &&
+ ext2fs_has_feature_orphan_present(fs->super))
+ return;
+
lastcheck = ext2fs_get_tstamp(sb, s_lastcheck);
if (lastcheck > ctx->now)
lastcheck -= ctx->time_fudge;
next prev parent reply other threads:[~2024-06-11 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 14:27 [PATCH 0/2] e2fsck: make sure orphan files are cleaned-up Luis Henriques (SUSE)
2024-06-11 14:27 ` Luis Henriques (SUSE) [this message]
2024-06-11 14:27 ` [PATCH 2/2] tests: new test to check that the orphan file is cleaned up Luis Henriques (SUSE)
2024-08-21 13:12 ` [PATCH 0/2] e2fsck: make sure orphan files are cleaned-up Luis Henriques
2024-10-19 0:46 ` Eric Sandeen
2024-10-21 9:24 ` Luis Henriques
2024-10-21 21:08 ` Eric Sandeen
2024-10-25 3:53 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611142704.14307-2-luis.henriques@linux.dev \
--to=luis.henriques@linux.dev \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.