From: Christoph Hellwig <hch@lst.de>
To: Shaun Tancheff <shaun.tancheff@hpe.com>
Cc: Christoph Hellwig <hch@lst.de>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios
Date: Tue, 11 Jun 2024 18:13:11 +0200 [thread overview]
Message-ID: <20240611161311.GA12257@lst.de> (raw)
In-Reply-To: <8e23be47-e542-4bb8-8da7-da7801c98e42@hpe.com>
On Tue, Jun 11, 2024 at 05:47:12PM +0700, Shaun Tancheff wrote:
>> const struct address_space_operations *a_ops = mapping->a_ops;
>> + size_t chunk = mapping_max_folio_size(mapping);
>
> Better to default chunk to PAGE_SIZE for backward compat
> + size_t chunk = PAGE_SIZE;
>
>> long status = 0;
>> ssize_t written = 0;
>>
>
> Have fs opt in to large folio support:
>
> + if (mapping_large_folio_support(mapping))
> + chunk = PAGE_SIZE << MAX_PAGECACHE_ORDER;
I don't think you've actually read the code, have you?
next prev parent reply other threads:[~2024-06-11 16:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 16:36 support large folios for NFS Christoph Hellwig
2024-05-27 16:36 ` [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Christoph Hellwig
2024-05-27 18:17 ` Matthew Wilcox
2024-05-28 8:12 ` Christoph Hellwig
2024-05-28 15:23 ` Daniel Gomez
2024-05-28 16:50 ` Matthew Wilcox
2024-05-28 19:01 ` Daniel Gomez
2024-06-11 10:47 ` Shaun Tancheff
2024-06-11 16:13 ` Christoph Hellwig [this message]
2024-06-12 1:41 ` Shaun Tancheff
2024-06-12 4:02 ` Christoph Hellwig
2024-05-27 16:36 ` [PATCH 2/2] nfs: add support for " Christoph Hellwig
2024-05-27 19:43 ` support large folios for NFS Sagi Grimberg
2024-05-28 21:03 ` [PATCH] nfs: Fix misuses of folio_shift() and folio_order() Matthew Wilcox (Oracle)
2024-05-29 5:15 ` Christoph Hellwig
2024-05-29 6:30 ` Christoph Hellwig
2024-05-29 14:31 ` Trond Myklebust
2024-05-28 21:05 ` support large folios for NFS Matthew Wilcox
2024-05-29 5:14 ` Christoph Hellwig
2024-05-29 13:35 ` Trond Myklebust
2024-05-29 21:59 ` Trond Myklebust
2024-05-31 6:14 ` hch
2024-06-07 5:29 ` hch
2024-06-07 7:57 ` Cedric Blancher
2024-06-07 15:32 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611161311.GA12257@lst.de \
--to=hch@lst.de \
--cc=anna@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=shaun.tancheff@hpe.com \
--cc=trond.myklebust@hammerspace.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.