From: Jason Gunthorpe <jgg@nvidia.com>
To: Daniel Mentz <danielmentz@google.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
Michael Shavit <mshavit@google.com>,
Nicolin Chen <nicolinc@nvidia.com>,
patches@lists.linux.dev, Ryan Roberts <ryan.roberts@arm.com>,
Mostafa Saleh <smostafa@google.com>
Subject: Re: [PATCH v2 01/10] iommu/arm-smmu-v3: Do not zero the strtab twice
Date: Wed, 12 Jun 2024 08:46:58 -0300 [thread overview]
Message-ID: <20240612114658.GV19897@nvidia.com> (raw)
In-Reply-To: <CAE2F3rBeE8gpjF-oU=g9i81bhrpeBiSNmVQ0tk+5BFk-LDMFow@mail.gmail.com>
On Tue, Jun 11, 2024 at 04:52:57PM -0700, Daniel Mentz wrote:
> I thought there was a guideline around not printing error messages on
> certain allocation failures because there'll be a generic OOM message
> that'll get printed.
Oops, right, C&P mistake. I removed it.
> Also, this driver never prints an error message
> when devm_kcalloc or devm_kzalloc fails, only on dmam_alloc_coherent
> failures.
dma_alloc_coherent generates the same dump as kzalloc on ENOMEM, I
guessed the intention was to add extra logging on the high order
allocations, but this allocation is larger than the dma one and
doesn't get a print so <shrug>
I was tempted to remove those prints too..
Thanks,
Jason
next prev parent reply other threads:[~2024-06-12 11:47 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 0:31 [PATCH v2 00/10] Tidy some minor things in the stream table/cd table area Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 01/10] iommu/arm-smmu-v3: Do not zero the strtab twice Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 0:50 ` Nicolin Chen
2024-06-11 0:50 ` Nicolin Chen
2024-06-11 23:52 ` Daniel Mentz
2024-06-12 11:46 ` Jason Gunthorpe [this message]
2024-06-11 0:31 ` [PATCH v2 02/10] iommu/arm-smmu-v3: Shrink the strtab l1_desc array Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 0:55 ` Nicolin Chen
2024-06-11 0:55 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 03/10] iommu/arm-smmu-v3: Add arm_smmu_strtab_l1/2_idx() Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 2:00 ` Nicolin Chen
2024-06-11 2:00 ` Nicolin Chen
2024-06-12 0:30 ` Daniel Mentz
2024-06-12 12:09 ` Jason Gunthorpe
2024-06-12 0:37 ` Daniel Mentz
2024-06-12 11:49 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 04/10] iommu/arm-smmu-v3: Add types for each level of the 2 level stream table Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 2:13 ` Nicolin Chen
2024-06-11 2:13 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 05/10] iommu/arm-smmu-v3: Reorganize struct arm_smmu_strtab_cfg Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 2:31 ` Nicolin Chen
2024-06-11 2:31 ` Nicolin Chen
2024-07-02 18:46 ` Will Deacon
2024-07-09 19:42 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 06/10] iommu/arm-smmu-v3: Remove strtab_base/cfg Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 2:36 ` Nicolin Chen
2024-06-11 2:36 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 07/10] iommu/arm-smmu-v3: Do not use devm for the cd table allocations Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 2:39 ` Nicolin Chen
2024-06-11 2:39 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 08/10] iommu/arm-smmu-v3: Shrink the cdtab l1_desc array Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 3:02 ` Nicolin Chen
2024-06-11 3:02 ` Nicolin Chen
2024-07-02 18:46 ` Will Deacon
2024-07-09 19:52 ` Jason Gunthorpe
2024-07-09 23:53 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 09/10] iommu/arm-smmu-v3: Add types for each level of the CD table Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 3:12 ` Nicolin Chen
2024-06-11 3:12 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 10/10] iommu/arm-smmu-v3: Reorganize struct arm_smmu_ctx_desc_cfg Jason Gunthorpe
2024-06-11 0:31 ` Jason Gunthorpe
2024-06-11 3:25 ` Nicolin Chen
2024-06-11 3:25 ` Nicolin Chen
2024-06-11 3:27 ` [PATCH v2 00/10] Tidy some minor things in the stream table/cd table area Nicolin Chen
2024-06-11 3:27 ` Nicolin Chen
2024-07-02 18:43 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612114658.GV19897@nvidia.com \
--to=jgg@nvidia.com \
--cc=danielmentz@google.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=ryan.roberts@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.