Re: [RFC PATCH v2] rtc: pcf2127: Add PPS capability through Seconds Interrupt

[kernel test robot <lkp@intel.com>]

Hi Bence,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linus/master v6.10-rc3 next-20240611]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cs-k-s-Bence/rtc-pcf2127-Add-PPS-capability-through-Seconds-Interrupt/20240611-231226
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link:    https://lore.kernel.org/r/20240611150458.684349-1-csokas.bence%40prolan.hu
patch subject: [RFC PATCH v2] rtc: pcf2127: Add PPS capability through Seconds Interrupt
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240612/202406121341.QCPOP2oG-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240612/202406121341.QCPOP2oG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406121341.QCPOP2oG-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-pcf2127.c: In function 'pcf2127_rtc_irq':
>> drivers/rtc/rtc-pcf2127.c:759:27: error: 'pps' undeclared (first use in this function)
     759 |                 pps_event(pps, &ts, PPS_CAPTUREASSERT, NULL);
         |                           ^~~
   drivers/rtc/rtc-pcf2127.c:759:27: note: each undeclared identifier is reported only once for each function it appears in
   drivers/rtc/rtc-pcf2127.c: In function 'pcf2127_probe':
>> drivers/rtc/rtc-pcf2127.c:1198:26: error: passing argument 1 of 'snprintf' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1198 |                 snprintf(&pps_info.name, PPS_MAX_NAME_LEN - 1, "%s", dev_name(dev));
         |                          ^~~~~~~~~~~~~~
         |                          |
         |                          char (*)[32]
   In file included from include/linux/kernel.h:33,
                    from arch/arm64/include/asm/cpufeature.h:26,
                    from arch/arm64/include/asm/ptrace.h:11,
                    from arch/arm64/include/asm/irqflags.h:10,
                    from include/linux/irqflags.h:18,
                    from include/linux/spinlock.h:59,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/slab.h:16,
                    from include/linux/resource_ext.h:11,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from drivers/rtc/rtc-pcf2127.c:20:
   include/linux/sprintf.h:12:35: note: expected 'char *' but argument is of type 'char (*)[32]'
      12 | __printf(3, 4) int snprintf(char *buf, size_t size, const char *fmt, ...);
         |                             ~~~~~~^~~
   cc1: some warnings being treated as errors


vim +/pps +759 drivers/rtc/rtc-pcf2127.c

   689	
   690	static irqreturn_t pcf2127_rtc_irq(int irq, void *dev)
   691	{
   692		struct pcf2127 *pcf2127 = dev_get_drvdata(dev);
   693		struct pps_event_time ts;
   694		unsigned int ctrl2;
   695		int ret = 0;
   696	
   697		/* First of all we get the time stamp... */
   698		pps_get_ts(&ts);
   699	
   700		ret = regmap_read(pcf2127->regmap, PCF2127_REG_CTRL2, &ctrl2);
   701		if (ret)
   702			return IRQ_NONE;
   703	
   704		if (pcf2127->cfg->ts_count == 1) {
   705			/* PCF2127/29 */
   706			unsigned int ctrl1;
   707	
   708			ret = regmap_read(pcf2127->regmap, PCF2127_REG_CTRL1, &ctrl1);
   709			if (ret)
   710				return IRQ_NONE;
   711	
   712			if (!(ctrl1 & PCF2127_CTRL1_IRQ_MASK || ctrl2 & PCF2127_CTRL2_IRQ_MASK))
   713				return IRQ_NONE;
   714	
   715			if (ctrl1 & PCF2127_BIT_CTRL1_TSF1 || ctrl2 & PCF2127_BIT_CTRL2_TSF2)
   716				pcf2127_rtc_ts_snapshot(dev, 0);
   717	
   718			if (ctrl1 & PCF2127_CTRL1_IRQ_MASK)
   719				regmap_write(pcf2127->regmap, PCF2127_REG_CTRL1,
   720					     ctrl1 & ~PCF2127_CTRL1_IRQ_MASK);
   721	
   722			if (ctrl2 & PCF2127_CTRL2_IRQ_MASK)
   723				regmap_write(pcf2127->regmap, PCF2127_REG_CTRL2,
   724					     ctrl2 & ~PCF2127_CTRL2_IRQ_MASK);
   725		} else {
   726			/* PCF2131. */
   727			unsigned int ctrl4;
   728	
   729			ret = regmap_read(pcf2127->regmap, PCF2131_REG_CTRL4, &ctrl4);
   730			if (ret)
   731				return IRQ_NONE;
   732	
   733			if (!(ctrl4 & PCF2131_CTRL4_IRQ_MASK || ctrl2 & PCF2131_CTRL2_IRQ_MASK))
   734				return IRQ_NONE;
   735	
   736			if (ctrl4 & PCF2131_CTRL4_IRQ_MASK) {
   737				int i;
   738				int tsf_bit = PCF2131_BIT_CTRL4_TSF1; /* Start at bit 7. */
   739	
   740				for (i = 0; i < pcf2127->cfg->ts_count; i++) {
   741					if (ctrl4 & tsf_bit)
   742						pcf2127_rtc_ts_snapshot(dev, i);
   743	
   744					tsf_bit = tsf_bit >> 1;
   745				}
   746	
   747				regmap_write(pcf2127->regmap, PCF2131_REG_CTRL4,
   748					     ctrl4 & ~PCF2131_CTRL4_IRQ_MASK);
   749			}
   750	
   751			if (ctrl2 & PCF2131_CTRL2_IRQ_MASK)
   752				regmap_write(pcf2127->regmap, PCF2127_REG_CTRL2,
   753					     ctrl2 & ~PCF2131_CTRL2_IRQ_MASK);
   754		}
   755	
   756		if (ctrl2 & PCF2127_BIT_CTRL2_AF)
   757			rtc_update_irq(pcf2127->rtc, 1, RTC_IRQF | RTC_AF);
   758		else if (ctrl2 & PCF2127_BIT_CTRL2_MSF)
 > 759			pps_event(pps, &ts, PPS_CAPTUREASSERT, NULL);
   760	
   761		pcf2127_wdt_active_ping(&pcf2127->wdd);
   762	
   763		return IRQ_HANDLED;
   764	}
   765	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki