From: "Marek Behún" <kabel@kernel.org>
To: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH 16/19] firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init()
Date: Wed, 12 Jun 2024 15:54:40 +0200 [thread overview]
Message-ID: <20240612135443.30239-17-kabel@kernel.org> (raw)
In-Reply-To: <20240612135443.30239-1-kabel@kernel.org>
Use devm_mutex_init() instead of mutex_init(), to properly call
mutex_destroy() on probe failure / driver unbind.
Signed-off-by: Marek Behún <kabel@kernel.org>
---
drivers/firmware/turris-mox-rwtm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
index 5f4dd919ce2e..f753e98f1ca7 100644
--- a/drivers/firmware/turris-mox-rwtm.c
+++ b/drivers/firmware/turris-mox-rwtm.c
@@ -486,7 +486,10 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rwtm);
- mutex_init(&rwtm->busy);
+ ret = devm_mutex_init(dev, &rwtm->busy);
+ if (ret < 0)
+ return ret;
+
init_completion(&rwtm->cmd_done);
rwtm->mbox_client.dev = dev;
--
2.44.2
next prev parent reply other threads:[~2024-06-12 13:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 13:54 [PATCH 00/19] Updates for turris-mox-rwtm driver Marek Behún
2024-06-12 13:54 ` [PATCH 01/19] firmware: turris-mox-rwtm: Do not complete if there are no waiters Marek Behún
2024-06-12 13:54 ` [PATCH 02/19] firmware: turris-mox-rwtm: Fix checking return value of wait_for_completion_timeout() Marek Behún
2024-06-13 8:06 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 03/19] firmware: turris-mox-rwtm: Use PAGE_SIZE instead of hardcoded 4096 Marek Behún
2024-06-13 8:01 ` Ilpo Järvinen
2024-06-13 9:54 ` Marek Behún
2024-06-12 13:54 ` [PATCH 04/19] firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6 Marek Behún
2024-06-13 8:02 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 05/19] firmware: turris-mox-rwtm: Use the boolean type where appropriate Marek Behún
2024-06-12 13:54 ` [PATCH 06/19] firmware: turris-mox-rwtm: Hide signature related constants behind macros Marek Behún
2024-06-12 13:54 ` [PATCH 07/19] firmware: turris-mox-rwtm: Fix driver includes Marek Behún
2024-06-12 13:54 ` [PATCH 08/19] firmware: turris-mox-rwtm: Use kobj_type's default_groups member for automatic sysfs files creation Marek Behún
2024-06-13 8:14 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 09/19] firmware: turris-mox-rwtm: Simplify debugfs code Marek Behún
2024-06-12 13:54 ` [PATCH 10/19] firmware: turris-mox-rwtm: Simplify driver kobject code Marek Behún
2024-06-13 8:31 ` Ilpo Järvinen
2024-06-13 9:55 ` Marek Behún
2024-06-13 10:19 ` Ilpo Järvinen
2024-06-13 13:31 ` Marek Behún
2024-06-13 13:37 ` Ilpo Järvinen
2024-06-13 15:39 ` Marek Behún
2024-06-13 15:44 ` Ilpo Järvinen
2024-06-12 13:54 ` [PATCH 11/19] firmware: turris-mox-rwtm: Return true error code if kobject_add() fails Marek Behún
2024-06-12 13:54 ` [PATCH 12/19] firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of driver .remove() Marek Behún
2024-06-12 13:54 ` [PATCH 13/19] firmware: turris-mox-rwtm: Use dev_err_probe() where possible Marek Behún
2024-06-12 13:54 ` [PATCH 14/19] firmware: turris-mox-rwtm: Rearrange probe calls Marek Behún
2024-06-12 13:54 ` [PATCH 15/19] firmware: turris-mox-rwtm: Drop redundant device pointer Marek Behún
2024-06-12 13:54 ` Marek Behún [this message]
2024-06-12 13:54 ` [PATCH 17/19] firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv member Marek Behún
2024-06-12 13:54 ` [PATCH 18/19] firmware: turris-mox-rwtm: Deduplicate command execution code Marek Behún
2024-06-12 13:54 ` [PATCH 19/19] firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612135443.30239-17-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.