From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: David Ahern <dsahern@kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Adrian Alvarado <adrian.alvarado@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
netdev@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1 0/3] bnxt_en: implement netdev_queue_mgmt_ops
Date: Wed, 12 Jun 2024 14:11:05 -0700 [thread overview]
Message-ID: <20240612141105.16880cde@kernel.org> (raw)
In-Reply-To: <80a1ea79-738d-404d-8b50-cc5eb432153e@davidwei.uk>
On Wed, 12 Jun 2024 11:19:47 -0700 David Wei wrote:
> Any validation would be done outside of this patchset, which only
> focuses on resetting an Rx queue. Reconfiguring page pools and HDS is
> orthogonal and unrelated to this patchset.
>
> The netdev core API consuming netdev_queue_mgmt_ops would be
> netdev_rx_queue_restart() added in [1].
>
> [1]: https://lore.kernel.org/lkml/20240607005127.3078656-2-almasrymina@google.com/
>
> Validation would be done at a layer above, i.e. whatever that calls
> netdev_rx_queue_restart(), as opposed to netdev_rx_queue_restart() or
> netdev_queue_mgmt_ops itself.
One could be tempted to pass a "configuration" object to tell the
driver that this queue will be required to run with HDS enabled.
I wonder where I've seen such a thing...
next prev parent reply other threads:[~2024-06-12 21:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 2:33 [PATCH net-next v1 0/3] bnxt_en: implement netdev_queue_mgmt_ops David Wei
2024-06-11 2:33 ` [PATCH net-next v1 1/3] bnxt_en: Add support to call FW to update a VNIC David Wei
2024-06-11 2:33 ` [PATCH net-next v1 2/3] bnxt_en: split rx ring helpers out from ring helpers David Wei
2024-06-14 20:01 ` Simon Horman
2024-06-11 2:33 ` [PATCH net-next v1 3/3] bnxt_en: implement netdev_queue_mgmt_ops David Wei
2024-06-14 20:07 ` Simon Horman
2024-06-18 4:36 ` David Wei
2024-06-11 2:40 ` [PATCH net-next v1 0/3] " David Ahern
2024-06-11 3:41 ` David Wei
2024-06-12 15:52 ` David Ahern
2024-06-12 18:19 ` David Wei
2024-06-12 21:11 ` Jakub Kicinski [this message]
2024-06-12 21:54 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612141105.16880cde@kernel.org \
--to=kuba@kernel.org \
--cc=adrian.alvarado@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.