From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: edumazet@google.com, pabeni@redhat.com, davem@davemloft.net,
dsahern@kernel.org, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
leitao@debian.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v2] net: dqs: introduce IFF_NO_BQL private flag for non-BQL drivers
Date: Wed, 12 Jun 2024 14:40:23 -0700 [thread overview]
Message-ID: <20240612144023.15f8032b@kernel.org> (raw)
In-Reply-To: <20240611033203.54845-1-kerneljasonxing@gmail.com>
On Tue, 11 Jun 2024 11:32:03 +0800 Jason Xing wrote:
> +++ b/include/linux/netdevice.h
> @@ -1649,6 +1649,9 @@ struct net_device_ops {
> * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to
> * ndo_hwtstamp_set() for all timestamp requests regardless of source,
> * even if those aren't HWTSTAMP_SOURCE_NETDEV.
> + * @IFF_NO_BQL: driver doesn't use BQL for flow control for now. It's used
> + * to check if we should create byte_queue_limits directory in dqs
> + * (see netdev_uses_bql())
Sorry for nit but since it's netdevice.h.. can we rephrase the comment
a bit? How about just:
+ * @IFF_NO_BQL: driver doesn't support BQL, don't create "byte_queue_limits"
+ * directories in sysfs.
next prev parent reply other threads:[~2024-06-12 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 3:32 [PATCH net-next v2] net: dqs: introduce IFF_NO_BQL private flag for non-BQL drivers Jason Xing
2024-06-12 21:40 ` Jakub Kicinski [this message]
2024-06-13 2:23 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612144023.15f8032b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=leitao@debian.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.