From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05E0C27C6E for ; Thu, 13 Jun 2024 15:41:34 +0000 (UTC) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by mx.groups.io with SMTP id smtpd.web10.11786.1718293292965753383 for ; Thu, 13 Jun 2024 08:41:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XdmpGTN4; spf=pass (domain: gmail.com, ip: 209.85.210.41, mailfrom: twoerner@gmail.com) Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6f9c1902459so691378a34.0 for ; Thu, 13 Jun 2024 08:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718293291; x=1718898091; darn=lists.yoctoproject.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=PdVohZcmp971R8qXOh9Pe+otIghemNlHYdqiPDnvavc=; b=XdmpGTN4LEJOIB8/5A6hj7bbGGcXKY8aoQAWEnUiyXGU0lzqPMFoCqsQOpfB0+DBfc 4wMBg7teVmtEWugib2qy6ySsk4cjSApr4G7sGYFyrOnBQRq9AaIVlXMc/MTfhrPi3b0J 5O3f0VZUCD/slHexyGbnRW8oQdZKClBgcaaoQXLoVe1f/vXGgNjl6kcGRmjBlnOosk87 yhd2Ui4fCwL9chuJ2mIrBYQJ7P8WG2Jnn/HVEgd4fgR2LLVbl6pHpjDILv5th2j23+Vn XPueKlznWPDqJz6yFpawuMHG4HFS+7oYxikt7PAUsaY2ezNfixE0ZWfw+yig7M0gsYpM 9rAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718293291; x=1718898091; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PdVohZcmp971R8qXOh9Pe+otIghemNlHYdqiPDnvavc=; b=tEBZ3OnFaoCBZ/C/cjEcPOw3f+0hpEzM9KkDr2BZjfi1iI90I0vQYBwHixHWE5J+0c va/frRGLdilhG4IZSRr6PmNAFfdkroq/gLvpUHAVMG0YPcPChTDEywcOinSWbOQ+7qIZ CyhDUFSfcWIzJlaY2l8KFtfKY6f21AxuHGFmIgN2ZerrbrOAZv3cE5wqDkvNruQhEhIT GjEAV6Ve/0N5u70P5KimazKwOEFAgryeM+Gdw+jkNCRS3IqQ1Ift1YLAZuds240AiA71 bVc5+kUPuQO5bG9t6gERlVXecC6JtGfg6OK6fBSW8IUr6kShr7Q1K97qDF6ctfSafu8d sC5w== X-Gm-Message-State: AOJu0Ywfow0gZ3izuADhfZ94Aww7f4b5arGQRRVxRjfqmSQ0SLskrdQn c17vkPjU8p0PI0GUv5T7Cw5gi61N1E2PAuNuuhfDySAHvFnybdY06/2tTQ== X-Google-Smtp-Source: AGHT+IGu9slP+xVirj/JDOZ8HE9MAkPN8+/Uck+EBp2tN/9PXand+NpyRFdTFYpT+JoKXhsLInInIg== X-Received: by 2002:a05:6830:1e5c:b0:6f9:baca:d1da with SMTP id 46e09a7af769-6fb93506efemr101098a34.11.1718293291343; Thu, 13 Jun 2024 08:41:31 -0700 (PDT) Received: from localhost (pppoe-209-91-167-254.vianet.ca. [209.91.167.254]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm62124985a.31.2024.06.13.08.41.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 08:41:30 -0700 (PDT) Date: Thu, 13 Jun 2024 11:41:28 -0400 From: Trevor Woerner To: yocto-patches@lists.yoctoproject.org Subject: Re: [yocto-patches] [meta-rockchip][PATCH v2 2/2] radxa-zero-3e: add Message-ID: <20240613154128.GB33883@localhost> References: <20240613133544.21164-1-twoerner@gmail.com> <20240613133544.21164-2-twoerner@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 13 Jun 2024 15:41:34 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto-patches/message/323 On Thu 2024-06-13 @ 04:11:01 PM, Quentin Schulz via lists.yoctoproject.org wrote: > Hi Trevor, > > On 6/13/24 3:35 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > The Radxa ZERO 3e is an ultra-small, high-performance single board computer > > based on the Rockchip RK3566, with a compact form factor, and rich interfaces. > > > > http://radxa.com/products/zeros/zero3e/ > > > > tech specs: > > - Rockchip RK3566 (4x Arm Cortex-A55 @ 1.6GHz) > > - Arm Mali-G52-2EE (OpenGL ES 1.1/2.0/3.0/3.1/3.2, Vulkan 1.1, OpenCL 2.0) > > - LPDDR4 RAM (1/2/3/8 GB) > > - µSD > > - GbE > > - 1x USB 2.0 Type C OTG, 1x USB 3.0 Type C Host > > - 1x µHDMI (1080p @ 60fps) > > - 1x MIPI CSI camera port > > - colour-coded 40-pin GPIO (uart, spi, i2c, pcm/i2s, pwm, gpio) > > - 72mm x 30mm > > > > NOTE: currently support for this board requires a U-Boot fork for the > > bootloader, and linux-next for the kernel. Support will probably come in linux > > kernel 6.11-ish, at which point U-Boot will then use that kernel's device tree > > which means U-Boot support will come after the release of whichever kernel > > includes support for this board. > > > > Signed-off-by: Trevor Woerner > > --- > > v2 changes: > > - copy the rk3568-based bl31/bl32 pieces to have rk3566-based names so the > > rest of the infrastructure works without tweaks > > - uncomment/implement the "remove-non-rockchip-arch" kernel scc > > - order/sort items > > - cleanup/fixup the linux-torvalds-next kernel recipe: > > - sort oe items based on the style guide > > - remove vestigial bits > > - use a commit id instead of a tag name > > - update license string > > - add DEFAULT_PREFERENCE=-1 > > - add COMPATIBLE_MACHINE > > --- > > README | 1 + > > conf/machine/include/rk3566.inc | 21 ++++++++++++++++++ > > conf/machine/radxa-zero-3e.conf | 12 ++++++++++ > > recipes-bsp/rkbin/rockchip-rkbin_git.bb | 12 ++++++++++ > > recipes-bsp/u-boot/u-boot_%.bbappend | 5 +++++ > > .../linux/linux-torvalds-next_git.bb | 22 +++++++++++++++++++ > > 6 files changed, 73 insertions(+) > > create mode 100644 conf/machine/include/rk3566.inc > > create mode 100644 conf/machine/radxa-zero-3e.conf > > create mode 100644 recipes-kernel/linux/linux-torvalds-next_git.bb > > > > diff --git a/README b/README > > index b21e92360dcc..a9a040a4308d 100644 > > --- a/README > > +++ b/README > > @@ -40,6 +40,7 @@ Status of supported boards: > > orangepi-5-plus > > rock-3a > > rock-4c-plus > > + radxa-zero-3e > > Maybe you want to order those alphabetically as well? (But they absolutely > aren't right now, so maybe another commit or... never :) ) > > > builds: > > marsboard-rk3066 > > radxarock > > diff --git a/conf/machine/include/rk3566.inc b/conf/machine/include/rk3566.inc > > new file mode 100644 > > index 000000000000..586d68806df6 > > --- /dev/null > > +++ b/conf/machine/include/rk3566.inc > > @@ -0,0 +1,21 @@ > > +SOC_FAMILY = "rk3566" > > + > > +DEFAULTTUNE ?= "cortexa55" > > + > > +ROCKCHIP_CLOSED_TPL ?= "1" > > + > > +require conf/machine/include/soc-family.inc > > +require conf/machine/include/rockchip-defaults.inc > > +require conf/machine/include/arm/armv8-2a/tune-cortexa55.inc > > +require conf/machine/include/rockchip-wic.inc > > + > > +KBUILD_DEFCONFIG ?= "defconfig" > > +KERNEL_FEATURES:append:rk3566 = " bsp/rockchip/remove-non-rockchip-arch-arm64.scc" > > +KERNEL_CLASSES = "kernel-fitimage" > > +KERNEL_IMAGETYPE ?= "fitImage" > > + > > +PREFERRED_PROVIDER_trusted-firmware-a = "rockchip-rkbin" > > +PREFERRED_PROVIDER_optee-os = "rockchip-rkbin" > > + > > +UBOOT_SUFFIX ?= "itb" > > +UBOOT_ENTRYPOINT ?= "0x06000000" > > diff --git a/conf/machine/radxa-zero-3e.conf b/conf/machine/radxa-zero-3e.conf > > new file mode 100644 > > index 000000000000..3a39d6c12a1f > > --- /dev/null > > +++ b/conf/machine/radxa-zero-3e.conf > > @@ -0,0 +1,12 @@ > > +#@TYPE: Machine > > +#@NAME: Radxa Zero 3E > > +#@DESCRIPTION: The Radxa ZERO 3e is an ultra-small, high-performance single board computer based on the Rockchip RK3566, with a compact form factor, and rich interfaces. > > +#http://radxa.com/products/zeros/zero3e/ > > + > > +require conf/machine/include/rk3566.inc > > + > > +PREFERRED_PROVIDER_virtual/kernel = "linux-torvalds-next" > > +KERNEL_DEVICETREE = "rockchip/rk3566-radxa-zero-3e.dtb" > > +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > + > > +UBOOT_MACHINE = "radxa-zero-3-rk3566_defconfig" > > diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb > > index f9724ddd5cd5..1b71414e27ca 100644 > > --- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb > > +++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb > > @@ -14,6 +14,7 @@ S = "${WORKDIR}/git" > > COMPATIBLE_MACHINE = "^$" > > COMPATIBLE_MACHINE:rk3308 = "rk3308" > > +COMPATIBLE_MACHINE:rk3566 = "rk3566" > > COMPATIBLE_MACHINE:rk3568 = "rk3568" > > COMPATIBLE_MACHINE:rk3588s = "rk3588s" > > @@ -36,6 +37,17 @@ do_deploy:rk3308() { > > install -m 644 ${S}/bin/rk33/rk3308_ddr_589MHz_uart?_m0_v*.bin ${DEPLOYDIR}/ddr-rk3308.bin > > } > > +# NOTE: the following are not typos > > +# the rk3566 uses the same bl31/2 as the rk3568 > > +do_deploy:rk3566() { > > + # Prebuilt TF-A > > + install -m 644 ${S}/bin/rk35/rk3568_bl31_v*.elf ${DEPLOYDIR}/bl31-rk3566.elf > > + # Prebuilt OPTEE-OS > > + install -m 644 ${S}/bin/rk35/rk3568_bl32_v*.bin ${DEPLOYDIR}/tee-rk3566.bin > > + # Prebuilt U-Boot TPL (DDR init) > > + install -m 644 ${S}/bin/rk35/rk3566_ddr_1056MHz_v1.21.bin ${DEPLOYDIR}/ddr-rk3566.bin > > Here you could use '*' instead of the version, up to you. > > > +} > > + > > do_deploy:rk3568() { > > # Prebuilt TF-A > > install -m 644 ${S}/bin/rk35/rk3568_bl31_v*.elf ${DEPLOYDIR}/bl31-rk3568.elf > > diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend b/recipes-bsp/u-boot/u-boot_%.bbappend > > index 1f5f63459627..dca43d2a4de0 100644 > > --- a/recipes-bsp/u-boot/u-boot_%.bbappend > > +++ b/recipes-bsp/u-boot/u-boot_%.bbappend > > @@ -2,6 +2,11 @@ require u-boot-rockchip.inc > > FILESEXTRAPATHS:prepend := "${THISDIR}/files:" > > +SRC_URI:radxa-zero-3e = "git://github.com/Kwiboo/u-boot-rockchip.git;protocol=https;branch=rk3xxx-2024.07;name=Kwiboo" > > +SRC_URI[Kwiboo.sha256sum] = "5d102a658262f6d2d4ea0664fe58b77db4a9eb1ebc89dbd8d6f5e75c9e563810" > > Is this actually used? I thought the git fetcher could handle corruption on > its own? > > > +SRCREV:radxa-zero-3e = "8cdf606e616baa36751f3b4adcfaefc781126c8c" > > +SRCREV:radxa-zero-3e:rk-u-boot-env = "8cdf606e616baa36751f3b4adcfaefc781126c8c" > > + > > Still don't like that we share the same recipe for essentially different > source code, but up to you. > > Just being curious, did you check the generic-rk3568 defconfig in upstream > U-Boot? > > > SRC_URI:append:rk-u-boot-env = " file://rockchip-enable-environment-mmc.cfg" > > SRCREV:rk-u-boot-env = "cdfcc37428e06f4730ab9a17cc084eeb7676ea1a" > > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb > > new file mode 100644 > > index 000000000000..88916587e259 > > --- /dev/null > > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb > > @@ -0,0 +1,22 @@ > > +FILESEXTRAPATHS:prepend := "${THISDIR}/linux-yocto-dev:" > > + > > +DESCRIPTION = "Linux Kernel" > > +SECTION = "kernel" > > +LICENSE = "GPL-2.0-only" > > +LIC_FILES_CHKSUM = "file://COPYING;md5=6bc538ed5bd9a7fc9398086aedcd7e46" > > + > > +DEFAULT_PREFERENCE = "-1" > > +COMPATIBLE_MACHINE = "" > > This doesn't work, I already made the same mistake some time ago in > meta-rockchip :) > > https://git.yoctoproject.org/meta-rockchip/commit/?id=36b07ec60c94eeeaa4866cc876bd6f7f8fd823e0 > > It needs to be "^$" D'oh! > > > +COMPATIBLE_MACHINE:radxa-zero-3e = "radxa-zero-3e" > > + > > +LINUX_VERSION = "6.10-rc3" > > +PV = "${LINUX_VERSION}+git${SRCPV}" > > +SRC_URI = " \ > > + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ > > + file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ > > + " > > You could provide a comment here stating which linuix-next tag this commit > is referring to. Sounds good. I'm going to send a v3 that also includes the radxa-zero-3w, which is very similar. > Looks good to me otherwise, > > Cheers, > Quentin > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#321): https://lists.yoctoproject.org/g/yocto-patches/message/321 > Mute This Topic: https://lists.yoctoproject.org/mt/106651710/900817 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >