From: "Marek Behún" <kabel@kernel.org>
To: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH v2 04/17] firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6
Date: Thu, 13 Jun 2024 18:10:32 +0200 [thread overview]
Message-ID: <20240613161045.29606-5-kabel@kernel.org> (raw)
In-Reply-To: <20240613161045.29606-1-kabel@kernel.org>
Use the ETH_ALEN macro instead of hardcoded 6 for MAC address length.
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/firmware/turris-mox-rwtm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
index b8deb13aed98..3a7969d15d27 100644
--- a/drivers/firmware/turris-mox-rwtm.c
+++ b/drivers/firmware/turris-mox-rwtm.c
@@ -10,6 +10,7 @@
#include <linux/debugfs.h>
#include <linux/dma-mapping.h>
#include <linux/hw_random.h>
+#include <linux/if_ether.h>
#include <linux/mailbox_client.h>
#include <linux/module.h>
#include <linux/mutex.h>
@@ -67,7 +68,7 @@ struct mox_rwtm {
int has_board_info;
u64 serial_number;
int board_version, ram_size;
- u8 mac_address1[6], mac_address2[6];
+ u8 mac_address1[ETH_ALEN], mac_address2[ETH_ALEN];
/* public key burned in eFuse */
int has_pubkey;
--
2.44.2
next prev parent reply other threads:[~2024-06-13 16:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 16:10 [PATCH v2 00/17] Updates for turris-mox-rwtm driver Marek Behún
2024-06-13 16:10 ` [PATCH v2 01/17] firmware: turris-mox-rwtm: Do not complete if there are no waiters Marek Behún
2024-06-13 16:10 ` [PATCH v2 02/17] firmware: turris-mox-rwtm: Fix checking return value of wait_for_completion_timeout() Marek Behún
2024-06-13 16:10 ` [PATCH v2 03/17] firmware: turris-mox-rwtm: Use macro constant instead of hardcoded 4096 Marek Behún
2024-06-13 16:15 ` Ilpo Järvinen
2024-06-13 17:51 ` Andy Shevchenko
2024-06-14 5:44 ` Arnd Bergmann
2024-06-17 10:57 ` Marek Behún
2024-06-17 11:01 ` Andy Shevchenko
2024-06-13 16:10 ` Marek Behún [this message]
2024-06-13 16:10 ` [PATCH v2 05/17] firmware: turris-mox-rwtm: Use the boolean type where appropriate Marek Behún
2024-06-13 16:10 ` [PATCH v2 06/17] firmware: turris-mox-rwtm: Hide signature related constants behind macros Marek Behún
2024-06-13 16:10 ` [PATCH v2 07/17] firmware: turris-mox-rwtm: Fix driver includes Marek Behún
2024-06-13 16:10 ` [PATCH v2 08/17] firmware: turris-mox-rwtm: Don't create own kobject type Marek Behún
2024-06-13 16:28 ` Ilpo Järvinen
2024-06-13 20:32 ` Andy Shevchenko
2024-06-14 5:58 ` Arnd Bergmann
2024-06-17 11:01 ` Marek Behún
2024-06-17 11:04 ` Marek Behún
2024-06-13 16:10 ` [PATCH v2 09/17] firmware: turris-mox-rwtm: Simplify debugfs code Marek Behún
2024-06-13 20:37 ` Andy Shevchenko
2024-06-17 11:10 ` Marek Behún
2024-06-13 16:10 ` [PATCH v2 10/17] firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of driver .remove() Marek Behún
2024-06-13 20:39 ` Andy Shevchenko
2024-06-17 11:13 ` Marek Behún
2024-06-13 16:10 ` [PATCH v2 11/17] firmware: turris-mox-rwtm: Use dev_err_probe() where possible Marek Behún
2024-06-13 20:49 ` Andy Shevchenko
2024-06-17 11:14 ` Marek Behún
2024-06-17 12:26 ` Andy Shevchenko
2024-06-17 13:04 ` Marek Behún
2024-06-13 16:10 ` [PATCH v2 12/17] firmware: turris-mox-rwtm: Initialize completion before mailbox Marek Behún
2024-06-13 20:56 ` Andy Shevchenko
2024-06-13 16:10 ` [PATCH v2 13/17] firmware: turris-mox-rwtm: Drop redundant device pointer Marek Behún
2024-06-13 16:10 ` [PATCH v2 14/17] firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() Marek Behún
2024-06-13 16:10 ` [PATCH v2 15/17] firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv member Marek Behún
2024-06-13 16:10 ` [PATCH v2 16/17] firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS Marek Behún
2024-06-13 16:10 ` [PATCH v2 17/17] firmware: turris-mox-rwtm: Deduplicate command execution code Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613161045.29606-5-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.