From: Jakub Kicinski <kuba@kernel.org>
To: Qingfang Deng <dqfext@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>,
Qingfang Deng <qingfang.deng@siflower.com.cn>
Subject: Re: [PATCH net-next] etherdevice: Optimize is_broadcast_ether_addr
Date: Thu, 13 Jun 2024 17:05:22 -0700 [thread overview]
Message-ID: <20240613170522.0961c781@kernel.org> (raw)
In-Reply-To: <20240613073441.781919-1-dqfext@gmail.com>
On Thu, 13 Jun 2024 15:34:41 +0800 Qingfang Deng wrote:
> Like is_zero_ether_addr, is_broadcast_ether_addr can also be optimized
> by using a 32-bit load if CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is set.
> Sign extension is used to populate the upper 16-bit of the 16-bit load.
Can you provide more context on why it's beneficial. I mean, there's a
lot of code in the kernel one could micro-optimize...
Show us the assembly, cycle counts, where it's used on fast paths...
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-14 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 7:34 [PATCH net-next] etherdevice: Optimize is_broadcast_ether_addr Qingfang Deng
2024-06-14 0:05 ` Jakub Kicinski [this message]
2024-06-18 6:47 ` Qingfang Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613170522.0961c781@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@siflower.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.