All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: stable@vger.kernel.org, ulf.hansson@linaro.org,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 6.1.y] mmc: davinci: Don't strip remove function when driver is builtin
Date: Thu, 13 Jun 2024 10:32:35 +0200	[thread overview]
Message-ID: <2024061322-sliceable-pucker-418c@gregkh> (raw)
In-Reply-To: <20240613055540.2284309-2-u.kleine-koenig@baylibre.com>

On Thu, Jun 13, 2024 at 07:55:41AM +0200, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Using __exit for the remove function results in the remove callback being
> discarded with CONFIG_MMC_DAVINCI=y. When such a device gets unbound (e.g.
> using sysfs or hotplug), the driver is just removed without the cleanup
> being performed. This results in resource leaks. Fix it by compiling in the
> remove callback unconditionally.
> 
> This also fixes a W=1 modpost warning:
> 
> WARNING: modpost: drivers/mmc/host/davinci_mmc: section mismatch in
> reference: davinci_mmcsd_driver+0x10 (section: .data) ->
> davinci_mmcsd_remove (section: .exit.text)
> 
> Fixes: b4cff4549b7a ("DaVinci: MMC: MMC/SD controller driver for DaVinci family")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20240324114017.231936-2-u.kleine-koenig@pengutronix.de
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> [ukleinek: Backport to v6.1.x]
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
>  drivers/mmc/host/davinci_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

What is the git id of this commit in Linus's tree?

thanks,

greg k-h

  reply	other threads:[~2024-06-13  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 18:22 FAILED: patch "[PATCH] mmc: davinci: Don't strip remove function when driver is" failed to apply to 6.1-stable tree gregkh
2024-06-13  5:55 ` [PATCH 6.1.y] mmc: davinci: Don't strip remove function when driver is builtin Uwe Kleine-König
2024-06-13  8:32   ` Greg KH [this message]
2024-06-13 13:47     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024061322-sliceable-pucker-418c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.